feat: add availability action to the contacts menu #6502
+245
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added
the
Feature: Integration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6502 +/- ##
============================================
- Coverage 23.46% 23.16% -0.31%
- Complexity 453 456 +3
============================================
Files 247 250 +3
Lines 11728 11864 +136
Branches 2212 2255 +43
============================================
- Hits 2752 2748 -4
- Misses 8656 8792 +136
- Partials 320 324 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
requested review from
SebastianKrupinski and
tcitworld
as code owners
st3iny
added
3. to review
3 tasks
| } | ||
|
|
||
| private function addContactsMenuScript(ContainerInterface $container): void { | ||
| // ServerVersion was added in 31, but we don't care about older versions anyway |
There was a problem hiding this comment.
But I already added a try catch around the container query 😨
I'll add it to the baseline for Nextcloud stable30 ...
EDIT: Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of nextcloud/server#44776
Requires nextcloud/server#49375 and nextcloud-libraries/nextcloud-vue#6238
Add a new action to the contacts menu to show the user's availability. The plan is to reuse the free-busy modal for this.
TODO
Screencasts
Avatar menu integration (from Talk)
2024-11-27.14-33-53.mp4
Contacts Menu integration (everywhere)
2024-11-27.14-35-29.mp4