Event attachments: Enable directory selection #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
Although folder selection is possible, the callback does not receive the picked node unless `allowDirectories(true)` is explicitly set. Signed-off-by: Daniel Kesselberg <[email protected]>
Fallback to the folder icon when a content type is missing. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
|
/backport to stable5.0 |
backportbot
bot
added
the
backport-request
kesselb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6534 +/- ##
=========================================
Coverage 23.33% 23.33%
Complexity 453 453
=========================================
Files 248 248
Lines 11777 11777
Branches 2257 2257
=========================================
Hits 2748 2748
Misses 8705 8705
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/backport to stable4.7 |
SebastianKrupinski
approved these changes
Nov 29, 2024
This was referenced Dec 3, 2024
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It’s possible to attach files to an event. An internal or public share link is stored within the event.
On the main branch, adding a folder currently doesn’t work (while selection is possible, the folder isn’t actually added). It’s unclear to me from the initial implementation #4251 whether folder support was intended or not.
Folders typically don’t have a content type returned, so I added a fallback to display the folder icon.
Warning
Adding another attendeed will generate a public share link instead of the internal link. This is apparently broken as well, I will try to address that in a follow up or log an issue.
How to test: