-
Notifications
You must be signed in to change notification settings - Fork 184
feat: import contacts from files via ocs #4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4654 +/- ##
============================================
+ Coverage 9.59% 68.12% +58.52%
- Complexity 266 295 +29
============================================
Files 128 27 -101
Lines 6409 869 -5540
Branches 1191 0 -1191
============================================
- Hits 615 592 -23
+ Misses 5673 277 -5396
+ Partials 121 0 -121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12b3baf
to
8790a7f
Compare
Morning. This PR should be in app/dav I think. Since the CardDAV can be used without the contacts UI. This will not work unless the contacts UI is installed. Refereance: nextcloud/server#49995 |
@st3iny accidentally clicke the approve button was ment to be a comment |
@SebastianKrupinski This decision was already made in planning. The API is supposed to be a part of Contacts. Please read #4632 for more information. |
It would be fine there too. To take some confusion we do hide a few calendar/contacts features from the user when the official calendar/contacts frontends are not there. I think this can be seen as one of those features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
This also needs an entry in capabilities in the style of this: https://github.com/tobiasKaminsky/declarativetest/blob/83716d84cde0efc6a6530adcd9b0219bdbb20e34/lib/Capabilities.php#L29
@tobiasKaminsky do you have an example for how to let the user pick from a list? We need this for the selection of the address book |
Signed-off-by: Richard Steinmetz <[email protected]>
176c4ff
to
858b57b
Compare
Resolves #4632
Requires nextcloud/server#54729
Does not need a version check against server, as the current main branch is only compatible with Nextcloud 32 upwards.
CI will be green after the server PR is merged (due to the new interface missing).
Is currently hard to test as there is no usage of the API anywhere.