Skip to content

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 26, 2025

Resolves #4632
Requires nextcloud/server#54729

Does not need a version check against server, as the current main branch is only compatible with Nextcloud 32 upwards.

CI will be green after the server PR is merged (due to the new interface missing).

Is currently hard to test as there is no usage of the API anywhere.

@st3iny st3iny self-assigned this Aug 26, 2025
@st3iny st3iny added enhancement New feature or request 2. developing Work in progress labels Aug 26, 2025
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.12%. Comparing base (9c9b007) to head (858b57b).

Files with missing lines Patch % Lines
lib/Controller/ImportController.php 87.50% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main    #4654       +/-   ##
============================================
+ Coverage     9.59%   68.12%   +58.52%     
- Complexity     266      295       +29     
============================================
  Files          128       27      -101     
  Lines         6409      869     -5540     
  Branches      1191        0     -1191     
============================================
- Hits           615      592       -23     
+ Misses        5673      277     -5396     
+ Partials       121        0      -121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@st3iny st3iny force-pushed the feat/import-ocs branch 3 times, most recently from 12b3baf to 8790a7f Compare August 29, 2025 09:44
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 29, 2025
@st3iny st3iny marked this pull request as ready for review August 29, 2025 10:38
@SebastianKrupinski
Copy link
Contributor

SebastianKrupinski commented Aug 29, 2025

Morning.

This PR should be in app/dav I think. Since the CardDAV can be used without the contacts UI. This will not work unless the contacts UI is installed.

Refereance: nextcloud/server#49995

@SebastianKrupinski
Copy link
Contributor

@st3iny accidentally clicke the approve button was ment to be a comment

@st3iny
Copy link
Member Author

st3iny commented Aug 29, 2025

This PR should be in app/dav I think. Since the CardDAV can be used without the contacts UI. This will not work unless the contacts UI is installed.

@SebastianKrupinski This decision was already made in planning. The API is supposed to be a part of Contacts. Please read #4632 for more information.

@ChristophWurst
Copy link
Member

This PR should be in app/dav I think. Since the CardDAV can be used without the contacts UI. This will not work unless the contacts UI is installed.

It would be fine there too. To take some confusion we do hide a few calendar/contacts features from the user when the official calendar/contacts frontends are not there. I think this can be seen as one of those features.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

This also needs an entry in capabilities in the style of this: https://github.com/tobiasKaminsky/declarativetest/blob/83716d84cde0efc6a6530adcd9b0219bdbb20e34/lib/Capabilities.php#L29

@ChristophWurst
Copy link
Member

This also needs an entry in capabilities in the style of this: https://github.com/tobiasKaminsky/declarativetest/blob/83716d84cde0efc6a6530adcd9b0219bdbb20e34/lib/Capabilities.php#L29

@tobiasKaminsky do you have an example for how to let the user pick from a list? We need this for the selection of the address book

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declarative action to import .vcf file
3 participants