Update workflows #5017
Update workflows #5017
Conversation
kesselb
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
|
Duplicate of #5013 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Also can we make the appstore-build-publish.yml a separate PR this has to be independently tested and if it needs to be reversed it will be easier to reverse |
|
It appears that David missed a couple of changes in #5013? |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
update-workflows
branch
from
a214571 to
c1443b3
Compare
renovate.json
Outdated
| "ignorePaths": [ | ||
| ".github/workflows/appstore-build-publish.yml", | ||
| ".github/workflows/appstore-conventional-build-publish.yml", | ||
| ".github/workflows/block-unconventional-commits.yml", | ||
| ".github/workflows/fixup.yml", | ||
| ".github/workflows/lint-eslint.yml", | ||
| ".github/workflows/lint-eslint-when-unrelated.yml", | ||
| ".github/workflows/lint-info-xml.yml", | ||
| ".github/workflows/lint-php-cs.yml", | ||
| ".github/workflows/lint-php.yml", | ||
| ".github/workflows/lint-stylelint.yml", | ||
| ".github/workflows/node-test.yml", | ||
| ".github/workflows/node.yml", | ||
| ".github/workflows/npm-audit-fix.yml", | ||
| ".github/workflows/npm-audit-fix-selective.yml", | ||
| ".github/workflows/openapi.yml", | ||
| ".github/workflows/pr-feedback.yml", | ||
| ".github/workflows/psalm-matrix.yml", | ||
| ".github/workflows/reuse.yml" | ||
| ], |
There was a problem hiding this comment.
Why do we want to ignore the workflows? I use renovate to updated these all the time
There was a problem hiding this comment.
That commit is optional. Those workflows are maintained at nextcloud/mail#12137. Having renovate and update them leads to the state that they are out of sync. That's probably not an issue, but also unnecessary work. What we do in mail is to update only the "local" workflows by renovate, and update the workflows from the template (with that script from over there) every here and then. Let me know if you want me to drop that commit, and you continue to update those workflow actions by renovate.
There was a problem hiding this comment.
Lets drop the renovate ignores... The workflows only need to be updated once a year... but the actions should be updated on a regular basis... and automating it is just much easier then running a manual update here and there
kesselb
force-pushed
the
update-workflows
branch
from
c1443b3 to
08fec9a
Compare
|
The new node.yml is failing... why do we need node.yml and node-test.yml? Looks like node.yml just does a build test... and so does node-test.yml |
Looking at nextcloud/.github#620 and nextcloud/photos#3178 it seems that the lockfile is not up-to-date. I'm running
I don't know, probably there are there for historical reasons. That validation step, package lock ok/nok, is currently only available in node.yml though. |
…k.json Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Please review carefully, as I'm not so familiar with the CI over here⚠️
a214571 is optional. We are doing the same in mail to avoid unnecessary action bumps since nextcloud/mail#12137