Feat: public transport routing #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
reviewed
Apr 4, 2025
ex_app/lib/all_tools/external.py
Outdated
| :param origin_lon: Longitude of the starting point | ||
| :param destination_lat: Latitude of the destination | ||
| :param destination_lon: Longitude of the destination | ||
| :param alternatives: the number of routes returned |
marcelklehr
reviewed
Apr 4, 2025
|
|
||
| LOCALE_DIR = os.path.join(os.path.dirname(os.path.dirname(__file__)), "locale") | ||
| current_translator = ContextVar("current_translator") | ||
| current_translator.set(translation(os.getenv("APP_ID"), LOCALE_DIR, languages=["en"], fallback=True)) |
Member
There was a problem hiding this comment.
Do we need to setup translations for this repo as well, then?
Member
Author
There was a problem hiding this comment.
Ahh right, no translations yet, I oversaw that. I'd say yes, settings should be translated?
marcelklehr
approved these changes
Apr 4, 2025
Member
marcelklehr
left a comment
marcelklehr
left a comment
There was a problem hiding this comment.
Settings work, tool works, the API itself yields weird routes as responses for me, but 🤷
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
janepie
force-pushed
the
feat/public-transport-routing
branch
from
a16c12d to
ee07051
Compare
marcelklehr
approved these changes
Apr 7, 2025
Member
|
woop woop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API key has to be set in admin settings, AI section