Feat: add departure time parameter #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
reviewed
Apr 17, 2025
marcelklehr
reviewed
Apr 17, 2025
janepie
force-pushed
the
feat/future-trains
branch
from
c2bbac0 to
1ee739a
Compare
julien-nc
reviewed
Apr 17, 2025
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Which timezone is used by the here API? Since no timezone is specified in the departureTime GET param, it might use UTC.
It would be nice to pass the user timezone (if that is supported by the API) or check if we need to convert the departure time to UTC.
Member
Author
|
If nothing is specified, it's using the local timezone at the origin location what I actually think is quite nice |
Member
|
Yeah, I think that makes sense, no? |
Member
|
Although, if departure_time is None, context agent sends a UTC time, which might be interpreted as local time, if we're departing from, say, Bejing |
Member
Author
|
It adds the timezone in that case so the API knows it's in UTC |
Member
Author
|
See here, next train in local time
|
Signed-off-by: Jana Peper <[email protected]>
janepie
force-pushed
the
feat/future-trains
branch
from
1ee739a to
1ae36b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now ask for connections in the future.
The requested time is interpreted in the timezone of the origin ("now" is still now). All time values in the response are returned in the timezone of each location.