feat: use poetry to manage dependencies and add an integration test #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
using llm2 Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/poetry-and-integration-tests
branch
2 times, most recently
from
24e3d40 to
d3e568f
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/poetry-and-integration-tests
branch
from
d3e568f to
010136f
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
changed the title
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/poetry-and-integration-tests
branch
from
081f52e to
962b613
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/poetry-and-integration-tests
branch
from
962b613 to
3865eb9
Compare
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/poetry-and-integration-tests
branch
from
439def5 to
981b151
Compare
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
requested review from
Copilot and
janepie
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dependency management using Poetry and adds an integration test workflow for the Nextcloud Assistant Context Agent.
- Configures Poetry in pyproject.toml and updates REUSE.toml with annotations for poetry.lock
- Adjusts the polling logic in nc_model.py to extend the timeout and differentiate between failed and timed out task statuses
- Adds a comprehensive GitHub Actions integration test workflow (.github/workflows/integration_test.yml)
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Added Poetry configuration for dependency management |
| ex_app/lib/nc_model.py | Updated polling loop timeout and error handling for task statuses |
| REUSE.toml | Extended annotations to include poetry.lock file |
| .github/workflows/integration_test.yml | Introduced integration test workflow for app integration testing |
Files not reviewed (1)
- Dockerfile: Language not supported
Co-authored-by: Copilot <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
janepie
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.