-
Notifications
You must be signed in to change notification settings - Fork 3
Feat: tool de-/activation #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janepie
commented
May 14, 2025
- adds a setting to toggle tools
- checks for availability of activated tools (if the relevant app is not installed, it's not imported)

Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Feedback/questions:
- We generally use "Sentence case", so "Context agent", "Public transport", "Office document generation" etc
- We try to avoid extra scrolling containers inside the main one. Could we just show all of them, or maybe grouping helps, or having 2 columns, left for active and right for inactive settings?
will do
These are declarative settings in AppAPI, the design is not defined here. Maybe @andrey18106 can help here? |
|
About the scrolling, maybe this can be changed to individual values instead of one value that combines all tools. This way each checkbox is independent and the generic rendering won't put them all in a scrollable area. |
|
Also 👍 ! |
"Context agent" is a proper name, though. Wondering if that still applies in this case (?) |
This takes up a lot more space as every entry needs a title line, and we create more db querys. I would prefer to keep it in one value, if we do not want it scrollable in general it's maybe best to change the UI of |
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
3b40ef6 to
0c7da0b
Compare
|
Yay, the integration test is already catching stuff 🎉 |
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
|
I really like the refactor we did 🎉 |
