add new automated tests to investigate the bug

Signed-off-by: Matthieu Gallien <[email protected]>
nextcloud · Jun 14, 2024 · 8f7aa24 · 8f7aa24
1 parent 36c4b9a
commit 8f7aa24
Show file tree

Hide file tree

Showing 2 changed files with 116 additions and 0 deletions.
diff --git a/test/testsynccfapi.cpp b/test/testsynccfapi.cpp
@@ -112,6 +112,12 @@ class TestSyncCfApi : public QObject
     Q_OBJECT
 
 private slots:
+    void initTestCase()
+    {
+        Logger::instance()->setLogFlush(true);
+        Logger::instance()->setLogDebug(true);
+    }
+
     void testVirtualFileLifecycle_data()
     {
         QTest::addColumn<bool>("doLocalDiscovery");
@@ -1384,6 +1390,62 @@ private slots:
         QVERIFY(fakeFolder.syncOnce());
         QVERIFY(itemInstruction(completeSpy, "A", CSYNC_INSTRUCTION_NONE));
     }
+
+    void testRemoteTypeChangeExistingLocalMustGetRemoved()
+    {
+        FakeFolder fakeFolder{FileInfo{}};
+        setupVfs(fakeFolder);
+
+        // test file change to directory on remote
+        fakeFolder.remoteModifier().mkdir("a");
+        fakeFolder.remoteModifier().insert("a/TESTFILE");
+        QVERIFY(fakeFolder.syncOnce());
+
+        fakeFolder.remoteModifier().remove("a/TESTFILE");
+        fakeFolder.remoteModifier().mkdir("a/TESTFILE");
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
+
+
+        // test directory change to file on remote
+        fakeFolder.remoteModifier().mkdir("a/TESTDIR");
+        QVERIFY(fakeFolder.syncOnce());
+
+        fakeFolder.remoteModifier().remove("a/TESTDIR");
+        fakeFolder.remoteModifier().insert("a/TESTDIR");
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
+    }
+
+    void testRecursiveRename()
+    {
+        FakeFolder fakeFolder{FileInfo{}};
+
+        // test file change to directory on remote
+        fakeFolder.remoteModifier().mkdir("folder1");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.1/TESTFILE1.1.1");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.1/TESTFILE1.2.1.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.1/TESTFILE1.2.1.2");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.1/TESTFILE1.2.1.3");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.2");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.2/test");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1/TESTFILE1.2.2.1.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1/TESTFILE1.2.2.1.2");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1/TESTFILE1.2.2.1.3");
+        QVERIFY(fakeFolder.syncOnce());
+
+        fakeFolder.remoteModifier().rename("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1", "folder1/folder1.2/folder1.2.2/folder1.2.2.1");
+        fakeFolder.remoteModifier().remove("folder1/folder1.2/folder1.2.2/test");
+        fakeFolder.remoteModifier().rename("folder1/folder1.2/folder1.2.2", "folder1/folder1.2/new name folder1.2.2");
+        fakeFolder.remoteModifier().rename("folder1/new name folder1.2", "folder1/new name folder1.2");
+        fakeFolder.remoteModifier().rename("folder1", "new name folder");
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
+    }
 };
 
 QTEST_GUILESS_MAIN(TestSyncCfApi)

diff --git a/test/testsyncengine.cpp b/test/testsyncengine.cpp
@@ -1727,6 +1727,60 @@ private slots:
         QVERIFY(itemDidCompleteSuccessfully(completeSpy, "A/abcdęfg.txt"));
         QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
     }
+
+    void testRemoteTypeChangeExistingLocalMustGetRemoved()
+    {
+        FakeFolder fakeFolder{FileInfo{}};
+
+        // test file change to directory on remote
+        fakeFolder.remoteModifier().mkdir("a");
+        fakeFolder.remoteModifier().insert("a/TESTFILE");
+        QVERIFY(fakeFolder.syncOnce());
+
+        fakeFolder.remoteModifier().remove("a/TESTFILE");
+        fakeFolder.remoteModifier().mkdir("a/TESTFILE");
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
+
+        // test directory change to file on remote
+        fakeFolder.remoteModifier().mkdir("a/TESTDIR");
+        QVERIFY(fakeFolder.syncOnce());
+
+        fakeFolder.remoteModifier().remove("a/TESTDIR");
+        fakeFolder.remoteModifier().insert("a/TESTDIR");
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
+    }
+
+    void testRecursiveRename()
+    {
+        FakeFolder fakeFolder{FileInfo{}};
+
+        // test file change to directory on remote
+        fakeFolder.remoteModifier().mkdir("folder1");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.1/TESTFILE1.1.1");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.1/TESTFILE1.2.1.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.1/TESTFILE1.2.1.2");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.1/TESTFILE1.2.1.3");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.2");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.2/test");
+        fakeFolder.remoteModifier().mkdir("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1/TESTFILE1.2.2.1.1");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1/TESTFILE1.2.2.1.2");
+        fakeFolder.remoteModifier().insert("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1/TESTFILE1.2.2.1.3");
+        QVERIFY(fakeFolder.syncOnce());
+
+        fakeFolder.remoteModifier().rename("folder1/folder1.2/folder1.2.2/test/folder1.2.2.1", "folder1/folder1.2/folder1.2.2/folder1.2.2.1");
+        fakeFolder.remoteModifier().remove("folder1/folder1.2/folder1.2.2/test");
+        fakeFolder.remoteModifier().rename("folder1/folder1.2/folder1.2.2", "folder1/folder1.2/new name folder1.2.2");
+        fakeFolder.remoteModifier().rename("folder1/new name folder1.2", "folder1/new name folder1.2");
+        fakeFolder.remoteModifier().rename("folder1", "new name folder");
+        QVERIFY(fakeFolder.syncOnce());
+        QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
+    }
 };
 
 QTEST_GUILESS_MAIN(TestSyncEngine)