Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown #6405

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Feb 2, 2024

to do:

Uploading other-errors.png…

Before:

before

After:

after

Systray message

systray

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Definitely such a big improvement! Only a minor change in the wording:

Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later

not blocking, but if possible we should link to the latest version or instructions on how to update, but that can be a follow-up :)

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good :)

@camilasan
Copy link
Member Author

Unable to connect to Nextcloud.
This version of the client is unsupported. Upgrade to version 3.0.0 or later

this text change will go in the server side PR: nextcloud/server#43281

@mgallien
Copy link
Collaborator

mgallien commented Feb 6, 2024

@camilasan it is unclear for me if you are waiting for more feedback or if we can merge this ?

@camilasan camilasan force-pushed the feature/minSupportDesktopVerMsg branch from e8e7375 to 92335db Compare February 6, 2024 16:51
@mgallien mgallien force-pushed the feature/minSupportDesktopVerMsg branch from 92335db to 8567acd Compare February 6, 2024 17:08
@mgallien mgallien force-pushed the feature/minSupportDesktopVerMsg branch from 8567acd to d6df907 Compare February 7, 2024 10:02
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

34.8% Coverage on New Code (required ≥ 80%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6405-d6df90796197f1203cf8586966a671d5bd97b4c6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan merged commit 1b305e4 into master Feb 7, 2024
10 of 13 checks passed
@camilasan camilasan deleted the feature/minSupportDesktopVerMsg branch February 7, 2024 17:24
@mgallien
Copy link
Collaborator

/backport to stable-3.12

Copy link

backportbot bot commented Feb 13, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6405/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 211233dd f197ce07 17ffc06d d6df9079

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6405/stable-3.12

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@mgallien
Copy link
Collaborator

/backport to stable-3.12

Copy link

backportbot bot commented Feb 13, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6405/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 211233dd f197ce07 17ffc06d d6df9079

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6405/stable-3.12

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a message to upgrade client if minimumSupportedDesktopVersion is thrown
5 participants