Use upstream Extra CMake Modules #6810
Open
+20
−1,073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
added
technical debt
building
tiziodcaio
reviewed
Jun 21, 2024
CMakeLists.txt
Outdated
| set(APPLE_SUPPRESS_X11_WARNING ON) | ||
|
|
||
| find_package(ECM 6.0.0 REQUIRED NO_MODULE) | ||
| set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules") |
There was a problem hiding this comment.
Update the URL to https://invent.kde.org/frameworks/extra-cmake-modules
mgallien
reviewed
Jun 26, 2024
Comment on lines
+78
to
+79
| include(KDEInstallDirs) | ||
| include(KDECMakeSettings) |
There was a problem hiding this comment.
I need to check how those two impact our windows builds
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
bugfix/upstream-ecm
branch
from
84172ea
to
eb8d6ed
Compare
|
AppImage file: nextcloud-PR-6810-eb8d6ed800d66755a6afb8f55dbadf7f5d241f4b-x86_64.AppImage |
mgallien
requested changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.