Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native UI #7101

Merged
merged 26 commits into from
Sep 13, 2024
Merged

Fix native UI #7101

merged 26 commits into from
Sep 13, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Sep 11, 2024

Continues #7077.

............................................................

⚠️ TODO:

  • align text/icon in buttons
  • fix talk icon in activity list

Screenshot 2024-09-13 at 11 31 38

  • remove black border from around the call notification

Screenshot 2024-09-13 at 12 29 01

............................................................

mac OS

Dark mode:

dark-theme-apps dark-theme-folders
dark-user-menu
add-files-dark

Light mode:

light-theme-apps light-theme-folders
light-user-menu
add-files-light

@camilasan camilasan force-pushed the bugfix/native-ui branch 2 times, most recently from 412ae09 to b1cbb41 Compare September 12, 2024 11:28
@camilasan camilasan marked this pull request as ready for review September 12, 2024 11:28
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outcome of call with @camilasan

Now

  • Alignment of search text
  • Native height and border radius
Screenshot 2024-09-12 at 15 40 00 Screenshot 2024-09-12 at 15 41 12
  • Wider account selection dropdown 150%

  • Folder menu: border should be as the apps dropdown and no separation lines between elements

Possibly follow up

  • Drop-down: same margin on all of them so that they dont "touch" the boundaries of the container element
  • "..." menus need to have some right margin so that they don't touch the boundaries of parent

@camilasan
Copy link
Member Author

@camilasan
Copy link
Member Author

camilasan commented Sep 12, 2024

Dropdown menus border-radius like native ones
Wider account selection dropdown 150%
Folder menu: border should be as the apps dropdown and no separation lines between elements

radiusradiusradius
moreradius
folders-menu-2

@camilasan
Copy link
Member Author

Alignment of search text
Native height and border radius

text-input-1
text-input-2

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment

src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
@mgallien
Copy link
Collaborator

/backport to stable-3.14

Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 very small comments

src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
Signed-off-by: Camila Ayres <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7101-6cde9c8cc8008a38b0fb4a239f473fef1559fcac-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
11 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 6fc3eb5 into master Sep 13, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/native-ui branch September 13, 2024 11:40
@camilasan camilasan mentioned this pull request Sep 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants