Add ability to provide multiple hardcoded server URLs via CMake define #7160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
Sep 23, 2024
mgallien
force-pushed
the
feature/hard-coded-servers
branch
from
fe2132a
to
2f0987f
Compare
claucambra
force-pushed
the
feature/hard-coded-servers
branch
2 times, most recently
from
a2d977b
to
efb18ea
Compare
|
Signed-off-by: Claudio Cambra <[email protected]>
…act a JSON array string describing multiple servers Signed-off-by: Claudio Cambra <[email protected]>
…rver JSON string Signed-off-by: Claudio Cambra <[email protected]>
…f override url Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…box selection url as url in setup page Signed-off-by: Claudio Cambra <[email protected]>
… error string in setup page Signed-off-by: Claudio Cambra <[email protected]>
…ive but have multiple servers Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
feature/hard-coded-servers
branch
from
efb18ea
to
c16b620
Compare
|
AppImage file: nextcloud-PR-7160-c16b6205f155fff54963501eff2f32b550a8ccad-x86_64.AppImage |
|
/backport to stable-3.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be done by feeding a JSON array string describing the multiple servers to the
APPLICATION_SERVER_URLdefine (so when using CMake, for example,-DAPPLICATION_SERVER_URL=[{\"name\": \"server1\", \"url\": \"https://c.a.com\"},{\"name\": \"server2\", \"url\": \"https://c.b.com\"}]'If the override server URLs are enforced (via
APPLICATION_SERVER_URL_ENFORCE) then a combo box will be shown letting the user pick the server in question