Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packaging capability to Mac Crafter #7173

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Add packaging capability to Mac Crafter #7173

merged 14 commits into from
Sep 23, 2024

Conversation

claucambra
Copy link
Collaborator

Adds the ability to create a pkg directly from mac crafter

@claucambra claucambra self-assigned this Sep 20, 2024
@claucambra
Add buildPackage function to mac crafter
9d8b27e 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add flag to build pkg in mac-crafter
8577a73 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add ability to sign pkg from mac-crafter
64e7d66 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add ability to notarise package from mac-crafter
7b76243 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add ability to build and sign sparkle tbz from mac-crafter
d60f02a 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add logging to packaging procedures in mac-crafter
d195186 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use appName for packaging step in mac-crafter
b5ace60 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove unused sparkleFile var
3b635c2 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Fix work build path used in mac crafter packaging stage
1e61986 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Create convenience function to convert architecture string to craft t…
b1ad91d 
…arget string

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Move packaging procedures into a single function in mac crafter
0b588b8 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Make specific step functions for packaging fileprivate in mac crafter
facec09 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add package command for mac crafter
a77aca3 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add note about packaging tooling in mac crafter
c405ce3 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra merged commit 59501ac into master Sep 23, 2024
11 of 14 checks passed
@claucambra claucambra deleted the feature/mac-crafter-package branch September 23, 2024 08:31
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7173-c405ce34d6908b5b6b542c760f7c8be9c3f62faf-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@backportbot backportbot bot mentioned this pull request Sep 23, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
os: 🍎 macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claucambra @nextcloud-desktop-bot @mgallien