Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/startup qml on windows #7199

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Bugfix/startup qml on windows #7199

merged 3 commits into from
Sep 25, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Sep 25, 2024

Close #7156

we import QtQuick module that also define Window component name

to avoid any ambiguity, just use a different name on our side

Signed-off-by: Matthieu Gallien <[email protected]>
will hopefuly make the qml engine search inside install dir within qml
sub folder

Close #7156

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien merged commit ea27b29 into master Sep 25, 2024
5 of 8 checks passed
@mgallien mgallien deleted the bugfix/startupQmlOnWindows branch September 25, 2024 14:43
@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7199-92f7247bc6e5c724ac6d0e858b77655da903d391-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Sep 25, 2024

@keunes
Copy link

keunes commented Sep 26, 2024

Thanks for the fix @mgallien! I'm hitting #7156 as well, which is particularly annoying because I have a conflict which I can't fix. Therefore I'm looking forward to this fix :-) Any idea of when it might be released into the wild (through the normal update channels)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Main window will not open on Windows
4 participants