Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constexpr function for platform detection #7220

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mgallien
Copy link
Collaborator

should decrease the cost of their usage when compared to preprocessor conditional directives

Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one!

should decrease the cost of their usage when compared to preprocessor
conditional directives

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the tidy/improvePlatformDetectionUtilityFunctions branch from af14ee4 to e6f6293 Compare September 27, 2024 07:26
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7220-e6f62930e99a33c4c6bcb1b8ad226c7d9fca5760-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit bb07ed4 into master Sep 27, 2024
11 of 15 checks passed
@mgallien mgallien deleted the tidy/improvePlatformDetectionUtilityFunctions branch September 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants