Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always remove folder icon when removing folder. #7238

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Always remove folder icon when removing folder. #7238

merged 5 commits into from
Nov 15, 2024
+64 −43

Commits on Nov 15, 2024

  1. Add step to remove Desktop.ini to removeFolder function. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @mgallien
    camilasan authored and mgallien committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cc2b5c6 View commit details
    Browse the repository at this point in the history

  2. f => folderToRemove. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @mgallien
    camilasan authored and mgallien committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    669754b View commit details
    Browse the repository at this point in the history

  3. Modernize NavigationPaneHelper class. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @mgallien
    camilasan authored and mgallien committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a3bc54f View commit details
    Browse the repository at this point in the history

  4. Add documentation about Utility::setupFavLink and Utility::removeFavL… 

    …ink.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @mgallien
    camilasan authored and mgallien committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    38eefd4 View commit details
    Browse the repository at this point in the history

  5. Modernize Utility::removeFavLink and Utility::setupFavLink. 

    Exit setupFavLink function when SHGetKnownFolderPath fails.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @mgallien
    camilasan authored and mgallien committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d5278c5 View commit details
    Browse the repository at this point in the history