Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication issues for macOS File Provider Extension #7240

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Fix authentication issues for macOS File Provider Extension #7240

merged 7 commits into from
Oct 11, 2024

Conversation

claucambra
Copy link
Collaborator

Depends on claucambra/NextcloudFileProviderKit#22

Improve the authentication phase of the File Provider Extension by:

  • Verifying account details are correct before signalling the extension is ready to perform file operations
  • Reattempting authentication check if necessary due to bad connection
  • Adding timeouts for said authentication check to prevent server overloading
  • Properly using user and userId roles to fix LDAP authentication issues

Fixes #6783

@claucambra claucambra self-assigned this Sep 30, 2024
@marcotrevisan marcotrevisan mentioned this pull request Sep 30, 2024
Open
8 tasks
@Rello Rello added this to the 3.14.2 milestone Oct 9, 2024
@claucambra
Try to authenticate new account details before setting them
ad2a2c4 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Retry authentication if connection timed out
9f9bcf0 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Wait for task to complete synchronously after setting up domain accou…
4d96dbb 
…nt rather than wrapping everything in task

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Fetch user profile (and user ID) when setting up domain account
cbf4ea5 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Properly provide both user-provided username AND backing user ID to F…
6f1322f 
…ile Provider Extension

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Handle userId correctly in File Provider Extension client interface
4d7b3ee 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Stop fetching user profile details now that is not necessary in file …
690303f 
…provider extension

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra merged commit b68da20 into master Oct 11, 2024
10 of 14 checks passed
@claucambra claucambra deleted the bugfix/mac-vfs-login-loop branch October 11, 2024 08:43
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7240-690303f952cff11db608ee9157eeead043769d18-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@backportbot backportbot bot mentioned this pull request Oct 11, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

App token login name does not match
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @Rello