Skip to content

README.md - specify envs are not read after installation #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README.md - specify envs are not read after installation #2085

wants to merge 1 commit into from

Conversation

gabriel-v
Copy link

@gabriel-v gabriel-v commented Oct 13, 2023 •
edited
Loading

closes #2086

@gabriel-v gabriel-v mentioned this pull request Oct 17, 2023
Open
@joshtrichards joshtrichards added docs feature: auto config (environment variables) Auto configuring via environment variables labels Oct 30, 2023
J0WI
J0WI reviewed Oct 24, 2024
View reviewed changes
README.md
);
```

And add keys to this file for each value expected to change (dbhost, dbport, passwords, etc).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And add keys to this file for each value expected to change (dbhost, dbport, passwords, etc).
And add keys to this file for each value expected to change (`dbhost`, `dbport`, `passwords`, etc).

J0WI
J0WI reviewed Oct 24, 2024
View reviewed changes
README.md

If one of these values needs to change, for example `MYSQL_HOST`, one must either manually edit the `config.php` file, or create a new custom configuration file (for example, `config/dbhostoverride.config.php`) with content:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```php

J0WI
J0WI reviewed Oct 24, 2024
View reviewed changes
README.md

And add keys to this file for each value expected to change (dbhost, dbport, passwords, etc).


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0WI J0WI J0WI left review comments

Assignees
No one assigned
Labels
docs feature: auto config (environment variables) Auto configuring via environment variables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image does not follow changes to MYSQL_HOST variable
3 participants
@gabriel-v @J0WI @joshtrichards