-
Notifications
You must be signed in to change notification settings - Fork 36
Add OpenAPI support #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI support #1018
Conversation
82d7c80 to
42eb9fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1018 +/- ##
=======================================
Coverage 33.97% 33.97%
=======================================
Files 25 25
Lines 1342 1342
Branches 50 50
=======================================
Hits 456 456
Misses 884 884
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it would be nice to also add the required headers into the spec.
We do have the following not explicitly required headers:
e2e-tokenX-NC-E2EE-COUNTERX-NC-E2EE-SIGNATURE
Is it possible to specify it?
Available with nextcloud/openapi-extractor#236 |
|
Just saw there is also getParam() which I didn't know about: nextcloud/openapi-extractor#237 |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
…-extractor expects Signed-off-by: provokateurin <[email protected]>
42eb9fc to
10b2885
Compare
|
Added the headers and params, but they are not documented the best. |
10b2885 to
3e3479a
Compare
|
Test failure are related, fixing now. |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
…scriptions Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
3e3479a to
5a746a3
Compare
|
/backport to stable31 |
No description provided.