Skip to content

Conversation

@provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin added 3. to review Waiting for reviews enhancement New feature or request labels May 13, 2025
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.97%. Comparing base (6ff3d88) to head (5a746a3).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   33.97%   33.97%           
=======================================
  Files          25       25           
  Lines        1342     1342           
  Branches       50       50           
=======================================
  Hits          456      456           
  Misses        884      884           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@provokateurin provokateurin requested a review from skjnldsv May 13, 2025 12:55
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@provokateurin provokateurin enabled auto-merge May 13, 2025 13:26
@provokateurin provokateurin disabled auto-merge May 13, 2025 13:27
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it would be nice to also add the required headers into the spec.

We do have the following not explicitly required headers:

  • e2e-token
  • X-NC-E2EE-COUNTER
  • X-NC-E2EE-SIGNATURE

Is it possible to specify it?

@provokateurin
Copy link
Member Author

Actually, it would be nice to also add the required headers into the spec.

Available with nextcloud/openapi-extractor#236

@provokateurin
Copy link
Member Author

Just saw there is also getParam() which I didn't know about: nextcloud/openapi-extractor#237

@provokateurin
Copy link
Member Author

@provokateurin
Copy link
Member Author

Added the headers and params, but they are not documented the best.

@provokateurin
Copy link
Member Author

Test failure are related, fixing now.

@provokateurin provokateurin enabled auto-merge May 15, 2025 12:26
@provokateurin provokateurin merged commit f92f2bb into master May 15, 2025
46 checks passed
@provokateurin provokateurin deleted the feat/openapi branch May 15, 2025 12:32
@provokateurin
Copy link
Member Author

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 20, 2025
@backportbot backportbot bot mentioned this pull request May 20, 2025
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants