feat: allow to create keys for shares with anonymous users #1315
+343
−255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susnux
commented
Dec 18, 2025
susnux
commented
- for feat: allow to create end-to-end encrypted external shares #1276
- for https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1250
- see also feat: allow to share with anonymous users end_to_end_encryption_rfc#71
susnux
added
3. to review
artonge
reviewed
Dec 19, 2025
Collaborator
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Wil the key be deleted by the frontend, or shall we add a listener to react to share events?
susnux
force-pushed
the
feat/public-shares
branch
from
b6eb2f9 to
74b5e76
Compare
artonge
reviewed
Jan 8, 2026
| 'end-to-end-encryption' => [ | ||
| 'enabled' => true, | ||
| 'api-version' => '2.0', | ||
| 'api-version' => '2.1', |
Collaborator
There was a problem hiding this comment.
Still unsure about that API bump
Contributor
Author
There was a problem hiding this comment.
We need to communicate this to the clients so they aware the server supports this new API.
Quickly checked clients source code and it seems they only check the major version at the moment so this should be safe (as its backwards compatible).
Collaborator
There was a problem hiding this comment.
Let's see then, worth case, it forces us to be better at version management
susnux
force-pushed
the
feat/public-shares
branch
from
74b5e76 to
a5dc020
Compare
artonge
approved these changes
Jan 9, 2026
susnux
force-pushed
the
feat/public-shares
branch
from
a5dc020 to
7e6eaa3
Compare
Contributor
Author
|
@artonge added an event listener to remove keys of deleted shares. |
susnux
force-pushed
the
feat/public-shares
branch
from
7e6eaa3 to
cdc464c
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/public-shares
branch
from
cdc464c to
edead41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.