Skip to content

feat: add UI for public encrypted shares #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 1 commit into from
Jan 12, 2026
Merged

feat: add UI for public encrypted shares #1345

susnux merged 1 commit into from
Jan 12, 2026

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 12, 2026

@susnux susnux force-pushed the feat/public-shares-ui branch from 779b75e to c052a40 Compare January 12, 2026 08:34
@susnux susnux added 3. to review Waiting for reviews enhancement New feature or request labels Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 1.31579% with 75 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...on/FilesSharingSidebarSectionPublicLinksDialog.vue 0.00% 40 Missing ⚠️
...rSection/FilesSharingSidebarSectionPublicLinks.vue 0.00% 9 Missing ⚠️
src/services/sharing.ts 0.00% 8 Missing ⚠️
src/services/metadata.ts 0.00% 4 Missing ⚠️
src/views/FilesSharingSidebarSections.vue 0.00% 4 Missing ⚠️
src/services/encryptionService.ts 0.00% 3 Missing ⚠️
src/store/keys.ts 0.00% 2 Missing and 1 partial ⚠️
...SidebarSection/FilesSharingSidebarSectionUsers.vue 0.00% 2 Missing ⚠️
src/services/api.ts 50.00% 1 Missing ⚠️
src/store/metadata.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@susnux susnux requested a review from artonge January 12, 2026 08:43
artonge
artonge reviewed Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good beside one question

@susnux susnux force-pushed the feat/public-shares-ui branch from c052a40 to 533555c Compare January 12, 2026 12:32
@susnux susnux force-pushed the feat/public-shares-ui branch from 533555c to 6053a31 Compare January 12, 2026 12:53
@susnux susnux merged commit c161631 into master Jan 12, 2026
47 of 49 checks passed
@susnux susnux deleted the feat/public-shares-ui branch January 12, 2026 13:43
@susnux susnux mentioned this pull request Jan 12, 2026
Merged
@tristan-k
Copy link

tristan-k commented Jan 15, 2026 •
edited
Loading

I just tried out the new feature but I'm unable to view any images. I can view the images just fine if don't use the public encrypted share link.

Screenshot 2026-01-15 at 15-55-41 Alle Dateien - Dateien - Nextcloud Screenshot 2026-01-15 at 15-58-09 Öffentliche Freigabe - Nextcloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge left review comments

@sorbaugh sorbaugh sorbaugh approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @tristan-k @artonge @sorbaugh