fix: Do not override default HTTP Client options - #238
Merged
Conversation
ArtificialOwl
approved these changes
Aug 14, 2026
ArtificialOwl
left a comment
ArtificialOwl
left a comment
Member
There was a problem hiding this comment.
should not be backported at it might break some setup
Currently, we override two options: 1. `verify`, which prevent using custom CA certificates 2. `allow_local_address`, which do not respect the instance wide setting Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/dont_overide_defaults
branch
from
August 16, 2026 15:29
28c69a7 to
47a429c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we override two options:
verify, which prevent using custom CA certificatesallow_local_address, which do not respect the instance wide setting🤖 AI (if applicable)