fix: update parent etag when changing acl rules #3326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
come-nc,
mgallien,
nfebe and
yemkareems
and removed request for
a team
come-nc
approved these changes
Oct 8, 2024
Contributor
|
Maybe add a comment before the line to explain |
provokateurin
approved these changes
Oct 8, 2024
Member
|
I think there was an issue about this problem but I can't find it anymore. |
Member
|
Ah found it: nextcloud/desktop#7150 |
|
tested with desktop client |
Member
|
/backport to stable30 |
Member
|
/backport to stable29 |
Member
|
/backport to stable28 |
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that sync clients can pickup on the fact that a user might have gained/lost access to a file.
It also updates the etag for users that don't have any changes, but it's better to be on the safe side here and figuring out which users are affected would add significant complexity.