Skip to content

perf: Make oc_group_folders.options a VARCHAR(255)#4863

Open
CarlSchwan wants to merge 1 commit into
masterfrom
carl/options-varchar
Open

perf: Make oc_group_folders.options a VARCHAR(255)#4863
CarlSchwan wants to merge 1 commit into
masterfrom
carl/options-varchar

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

Allow to query this column without on-disk temp table on MySQL

πŸ€– AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Allow to query this column without on-disk temp table on MySQL

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan added 3. to review Items that need to be reviewed php Items related to PHP updates and code issues performance πŸš€ labels Jul 2, 2026

@come-nc come-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the value always fit?

@solracsf

solracsf commented Jul 8, 2026

Copy link
Copy Markdown
Member

@come-nc, yes, as far as I understand it.

Reasoning: the column is typed array{separate-storage?: bool} and has only that single boolean key since it was introduced. createFolder is the sole writer. If someone adds enough option keys to exceed 255 later, strict mode (default since MySQL 5.7 / MariaDB 10.2.4) fails the insert loudly, so it forces a column widening rather than corrupting silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Items that need to be reviewed performance πŸš€ php Items related to PHP updates and code issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants