rename team folder to group folder - #5075
Open
Fin-c wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com> GPT-5.6 Sol Signed-off-by: Fin Clausen <Fin.Clausen@dataport.de>
Fin-c
force-pushed
the
feature/rename_teamfolders_to_groupfolders
branch
from
September 3, 2026 08:25
c6ec90e to
52dae13
Compare
jospoortvliet
approved these changes
Sep 3, 2026
jospoortvliet
left a comment
jospoortvliet
left a comment
Member
There was a problem hiding this comment.
I looked through it, but didn't test (from what I can see it's all string changes).
- removing of team spaces is good move, we don't use the term
- all the changes in comments in the code - sure, maybe not that critical, but not a problem.
- warnings and such in UI - all look fine to me.
So 🐘 it looks good.
Minor thing - I think we should name it Group folders (capital, just like with Team). But to me, that's not a blocker, I rather get this in as-is than not at all.
|
Blocked by nextcloud/server#63989 and #5076 |
|
/backport to stable35 |
Contributor
Author
|
Blocked by #5071 |
artonge
requested changes
Sep 3, 2026
|
|
||
| #[\Override] | ||
| public function getName(): string { | ||
| return $this->l10n->t('Team spaces'); |
Contributor
There was a problem hiding this comment.
This will have to go in after the release for 35.0.1 as we cannot change translated strings that late in the process.
Please revert all of them and only keep non-translated strings
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the Team folders back to group folders
#5063
🤖 AI (if applicable)