feat: admin setting to enable navigation link per default #54
Conversation
lib/AppInfo/Application.php
Outdated
| $navlink_default = $this->config->getAppValue(Application::APP_ID, 'navlink_default'); | ||
| if ($this->config->getUserValue($userId, self::APP_ID, 'navigation_enabled', $navlink_default) === '1') { |
There was a problem hiding this comment.
$navlinkDefault would be better suited to be consistent with camel case naming style
lib/Settings/Admin.php
Outdated
| $navlink_default = $this->config->getAppValue(Application::APP_ID, 'navlink_default', '0'); | ||
|
|
||
| $adminConfig = [ | ||
| 'client_id' => $clientID, | ||
| // Do not expose the saved client secret to the user | ||
| 'client_secret' => $clientSecret !== '' ? 'dummySecret' : '', | ||
| 'oauth_instance_url' => $oauthUrl, | ||
| 'use_popup' => ($usePopup === '1'), | ||
| 'navlink_default' => ($navlink_default === '1'), |
janepie
force-pushed
the
feat/admin-setting-for-default-navlink
branch
from
6958277 to
4b0dddc
Compare
Signed-off-by: Jana Peper <[email protected]>
janepie
force-pushed
the
feat/admin-setting-for-default-navlink
branch
from
4b0dddc to
bbb9d51
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
resolves #20