feat: use outline icons instead of solid ones #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anupam Kumar <[email protected]>
Signed-off-by: Anupam Kumar <[email protected]>
kyteinsky
force-pushed
the
feat/outline-icons
branch
from
f8ad101 to
1999598
Compare
julien-nc
approved these changes
Jul 9, 2025
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Even fixed Vue 3 migration mistakes (NcTextField now has a slot icon instead of using the default one) 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In admin settings, the help icon and the authentication icons changed
In personal settings, the key icon was changed, and the heading is left-aligned for consistency. The basic auth UI and logic is also ported from the admin settings.
For the vue3 migration, it looks like
NcInputFieldandNcTextFieldneed icon slots now.