Skip to content

Conversation

@lukasdotcom
Copy link
Member

@lukasdotcom lukasdotcom commented Aug 29, 2025

Resolves: #264
I tested it with french on english audio and it did use french quotation marks << instead of the english ones ".
image

Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm a bit late to the party.

There's something missing. I should have been more explicit in the issue.
It would be nice to let the user choose a language in which they will talk in the audio chat feature. I think another (yeah one more) field in the user settings would be good.
Something like "Audio chat language" with a hint like "If you set this, it can improve the transcription of what you say when using the audio chat".

This field value would be stored as a user config value (in oc_preferences with IConfig) and used by the AudioToAudioChatProvider when calling openAiAPIService->transcribeFile.

@lukasdotcom
Copy link
Member Author

Updated the pr to now be able to set a default in the user settings for the language that is used. Still supports the other way of selecting the language for a specific transcribe audio task.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work perfectly.
Optional tit picking (for later maybe): The default input value for language in AudioToTextProvider could be set to the one chosen in the personal settings of the user. In the end it does not matter so much because default is the selected value and it will result in selecting the correct value when processing the task.

@kyteinsky kyteinsky merged commit 2711ee7 into main Oct 13, 2025
29 checks passed
@kyteinsky kyteinsky deleted the feat/stt-lang branch October 13, 2025 11:21
@kyteinsky
Copy link
Contributor

ah, noticed after merging there was a comment. Maybe the adjustment can be included in a new PR if required @lukasdotcom ?

@kyteinsky kyteinsky mentioned this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to force language for STT

4 participants