Store the model list in the DB #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
fix/272/unreachable-service
branch
from
05d54e7 to
2d4f190
Compare
marcelklehr
reviewed
Oct 7, 2025
marcelklehr
reviewed
Oct 7, 2025
marcelklehr
reviewed
Oct 7, 2025
| if (!$refresh) { | ||
| if ($this->modelsMemoryCache !== null) { | ||
| $this->logger->debug('Getting OpenAI models from the memory cache'); | ||
| return $this->modelsMemoryCache; |
Member
There was a problem hiding this comment.
The memory cache is never populated when the value is retrieved from the distributed cache. Might be nice to do that
marcelklehr
reviewed
Oct 7, 2025
marcelklehr
reviewed
Oct 7, 2025
marcelklehr
reviewed
Oct 8, 2025
Member
marcelklehr
left a comment
marcelklehr
left a comment
There was a problem hiding this comment.
did not test. looks good.
marcelklehr
approved these changes
Oct 8, 2025
…e is accessed and on upgrade to 3.9.0 and once a day in a bg job Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/272/unreachable-service
branch
from
461afcc to
ead25f3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #272
This prevents the model list to be obtained with a network request to the external service when populating the enum values of the task processing providers (which is a problem when the remote service is unreachable).
We now store the model list in a permanent storage (the DB) and it is only refreshed: