chore: backport nextcloud-31 bump commits #759

saw-jan · 2025-01-24T11:00:28Z

Description

Backport

Related work packages

WP#61036

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Updated CHANGELOG.md file

* add support for nextcloud master Signed-off-by: nabim777 <[email protected]> * add ocs endpoint on groupfolder on tests Signed-off-by: nabim777 <[email protected]> * review address Signed-off-by: nabim777 <[email protected]> * call getVersionString from another class Signed-off-by: nabim777 <[email protected]> * review address for group folder test Signed-off-by: nabim777 <[email protected]> * using DRY concept Signed-off-by: nabim777 <[email protected]> * group folders Signed-off-by: nabim777 <[email protected]> * review address Signed-off-by: nabim777 <[email protected]> * set the version inside hroupfoldercontext file Signed-off-by: nabim777 <[email protected]> * check if groupfolderDavpath is set or not Signed-off-by: nabim777 <[email protected]> --------- Signed-off-by: nabim777 <[email protected]>

Signed-off-by: nabim777 <[email protected]>

Signed-off-by: sagar <[email protected]>

Signed-off-by: Sagar <[email protected]>

…#717) * Exclude API test for master branch as well for Nightly CI release/2.7 Signed-off-by: Sagar <[email protected]> * false Signed-off-by: Sagar <[email protected]> --------- Signed-off-by: Sagar <[email protected]>

Signed-off-by: Julien Veyssier <[email protected]>

Signed-off-by: Saw-jan <[email protected]>

* ci: bump nextcloud version to 32 Signed-off-by: Saw-jan <[email protected]> * chore: add changelog entry Signed-off-by: Saw-jan <[email protected]> * ci: use nextcloud stable31 Signed-off-by: Saw-jan <[email protected]> --------- Signed-off-by: Saw-jan <[email protected]>

Signed-off-by: nabim777 <[email protected]>

Signed-off-by: Saw-jan <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

github-actions · 2025-01-27T08:32:14Z

JS Code Coverage

Coverage after merging backport/nc-31-bump into release/2.7 will be

87.58%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
bootstrap.js	0%	0%	0%	0%	1, 1–7
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–17, 2–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–25, 3–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
reference.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60, 7–9
utils.js	71.43%	33.33%	50%	73.85%	10–14, 17–26, 6–9
src/components
AdminSettings.vue	96.24%	94.08%	95.31%	96.58%	1018–1020, 1055–1058, 1094–1096, 1116–1119, 527–528, 676, 688–690, 702, 702, 702–707, 710–711, 715–716, 719–720, 724–725, 735–740, 801–803, 815–818, 831–833
OAuthConnectButton.vue	85.27%	63.64%	100%	86.84%	44–51, 59–64, 67–71
PersonalSettings.vue	90.16%	94.44%	85.71%	89.88%	100, 110–115, 118–127, 99
src/components/admin
FieldValue.vue	100%	100%	100%	100%
FormHeading.vue	100%	100%	100%	100%
TermsOfServiceUnsigned.vue	100%	100%	100%	100%
TextInput.vue	100%	100%	100%	100%
src/components/icons
ClippyIcon.vue	100%	100%	100%	100%
OpenProjectIcon.vue	100%	100%	100%	100%
src/components/settings
CheckBox.vue	100%	100%	100%	100%
SettingsTitle.vue	96.74%	85.71%	100%	97.53%	46–48
src/components/tab
EmptyContent.vue	97.22%	89.47%	100%	98.06%	92–96
SearchInput.vue	95.27%	92.96%	94.74%	95.73%	134–135, 188, 199–204, 263–265, 281–283, 287–292
WorkPackage.vue	86.07%	73.17%	93.33%	87.42%	102–111, 124–126, 137–141, 151–153, 171–177, 215, 215–220, 220, 220–231, 76–77
src/filesPlugin
filesPlugin.js	0%	0%	0%	0%	1, 1, 10, 100–104, 11–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
filesPluginLessThan28.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–78, 8–9
src/utils
workpackageHelper.js	89.72%	82.14%	88.89%	92.02%	153–154, 18–22, 29, 29, 31, 31, 45–47, 49, 49, 49–51, 94–99
src/views
CreateWorkPackageModal.vue	94.38%	86.54%	91.67%	95.55%	353–355, 358, 459–462, 467–472, 477–482, 488–491, 494, 510, 510, 550–554, 564–566, 585–587, 617–619, 641–643, 652–656
Dashboard.vue	77.40%	80.39%	61.90%	78.01%	103–108, 115, 119–120, 125, 128, 131–134, 139–141, 182–188, 194–197, 199–209, 238–246, 259–273, 51, 63, 88–91, 98–99
LinkMultipleFilesModal.vue	100%	100%	100%	100%
ProjectsTab.vue	94.91%	94.23%	93.33%	95.07%	113–116, 142, 153–154, 188–198, 246–248

github-actions · 2025-01-27T08:32:35Z

PHP Code Coverage

Coverage after merging backport/nc-31-bump into release/2.7 will be

60.64%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	19, 26–35
ServerVersionHelper.php	0%	100%	0%	0%	17–18, 21, 24
server/apps/integration_openproject/lib/AppInfo
Application.php	7.41%	100%	25%	6%	102, 104–107, 109, 111, 113, 117–120, 122–133, 135, 138, 142, 146–148, 75–77, 80–84, 86–91, 93–94, 97
server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	42, 44–46, 55–56
server/apps/integration_openproject/lib/Controller
ConfigController.php	64.76%	100%	50%	65.37%	136, 153–154, 156, 158–160, 162–165, 168–169, 171, 213, 223, 227–229, 293–297, 407–409, 411–413, 418–421, 462, 550–553, 555–556, 559, 567–571, 582, 596–599, 607–608, 612–615, 629–633, 635–636, 638–654, 671–676, 678–679, 681–683, 686, 688–704, 717–724, 726–729, 731–735, 744–749
DirectDownloadController.php	0%	100%	0%	0%	37–39, 54–56, 58–65
DirectUploadController.php	70.83%	100%	100%	70%	141–143, 186–188, 199, 203–206, 208, 218, 225, 241–243, 245–246, 249–254, 257, 259, 267–269, 275–277, 285–287, 302–304, 323, 328, 334
FilesController.php	72.95%	100%	83.33%	72.41%	182–183, 245, 250–253, 255, 257–270, 273–274, 276–277, 281–284, 287, 293
OpenProjectAPIController.php	85.60%	100%	80%	85.92%	140, 181, 205, 231–234, 237–244, 246–250, 252, 264, 273, 291, 300, 370, 372, 422, 424, 444, 446, 493, 495, 521–524, 527–531, 533, 738–742, 97
server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	102, 109, 116–117, 119, 121–138, 70–74, 81, 88, 95
server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	16
server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	0%	100%	0%	0%	48, 56–57, 60–63, 65
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	41–43, 47–50, 52, 54, 57–58, 60, 62–65, 67–70, 72–74
BeforeUserDeletedListener.php	0%	100%	0%	0%	48, 55–56, 58–61, 63
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	18–19, 21–23, 25
LoadSidebarScript.php	0%	100%	0%	0%	100, 102, 104–105, 107, 109, 111, 113–122, 75–91, 96–97, 99
OpenProjectReferenceListener.php	0%	100%	0%	0%	54–55, 58–59, 62–63, 65–68
TermsOfServiceEventListener.php	0%	100%	0%	0%	59–60, 65–66, 68–69, 71–73, 76–80
UserChangedListener.php	0%	100%	0%	0%	52, 59–60, 63–68, 71
server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	47, 57–65, 67–75, 77–79, 81
Version2310Date20230116153411.php	0%	100%	0%	0%	46, 49–52, 54–79, 81–82, 84
Version2400Date20230504144300.php	0%	100%	0%	0%	47, 57–60
Version2640Date20240628114301.php	0%	100%	0%	0%	52, 64–66, 69–70, 73
server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	102, 108–111, 114–116, 119, 123, 157, 165–166, 174, 52, 59, 66, 73–75
server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	103–104, 107–118, 121–122, 124–125, 128–137, 139–143, 66–69, 76, 83, 91, 93, 96
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	100–102, 125–129, 131, 80–93, 95–99
DirectDownloadService.php	88.46%	100%	100%	87.50%	66–67, 69
DirectUploadService.php	42.86%	100%	66.67%	40%	112, 118, 79–82, 84–92
OauthService.php	32.08%	100%	40%	31.25%	104–112, 123–130, 79–87, 89–95
OpenProjectAPIService.php	75.88%	100%	76.36%	75.84%	1040–1042, 1044–1046, 1049–1053, 1055–1057, 1066–1069, 1072–1074, 1076, 1079–1084, 1088–1089, 1120–1123, 1142–1149, 1165–1166, 1173–1175, 1177–1180, 1184, 1193, 1211, 1213–1216, 1218–1223, 1365, 1377, 1380, 1402, 1405, 1415–1420, 1545–1547, 1549–1550, 1554–1555, 1557, 1559,

nabim777

LGTM 👍

github-actions · 2025-02-08T02:34:48Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

saw-jan force-pushed the backport/nc-31-bump branch 16 times, most recently from eeb8584 to b1585a8 Compare January 27, 2025 06:17

nabim777 and others added 14 commits January 27, 2025 12:49

exclude nextcloud 31 on release/2.7 for nightly CI release (#712)

a97a446

Signed-off-by: nabim777 <[email protected]>

Fix release branch failure for nightly CI (#714)

e95301c

Signed-off-by: sagar <[email protected]>

Fix nightly failure for CI (#715)

315d934

Signed-off-by: Sagar <[email protected]>

fix: safer getNextcloudVersion() using the version array (#719)

2922327

Signed-off-by: Julien Veyssier <[email protected]>

chore: initialize keycloak with realm, clients and users

64d40f1

Signed-off-by: Saw-jan <[email protected]>

docs: add information on initial realm setup

ae3a792

Signed-off-by: Saw-jan <[email protected]>

chore: add code linter make targets

4b921c7

Signed-off-by: Saw-jan <[email protected]>

chore: allow server path via env

39651d6

Signed-off-by: Saw-jan <[email protected]>

ci: use make targets in the ci

dc88ec0

Signed-off-by: Saw-jan <[email protected]>

revert the changes of api-tests file (#738)

a8381d7

Signed-off-by: nabim777 <[email protected]>

chore: pin nextcloud version to 31

d791cf4

Signed-off-by: Saw-jan <[email protected]>

ci: skip nextcloud master branch in release branches

5962dc2

Signed-off-by: Saw-jan <[email protected]>

saw-jan force-pushed the backport/nc-31-bump branch from b1585a8 to 5962dc2 Compare January 27, 2025 07:04

chore: Remove deprecated ILogger

f869d6a

Signed-off-by: Ferdinand Thiessen <[email protected]>

saw-jan marked this pull request as ready for review January 27, 2025 08:39

saw-jan requested review from individual-it and nabim777 and removed request for individual-it January 27, 2025 08:39

saw-jan self-assigned this Jan 27, 2025

nabim777 approved these changes Jan 27, 2025

View reviewed changes

individual-it approved these changes Jan 27, 2025

View reviewed changes

saw-jan merged commit 2d905c4 into release/2.7 Jan 27, 2025
16 of 17 checks passed

saw-jan deleted the backport/nc-31-bump branch January 27, 2025 09:31

github-actions bot added the feedback-requested label Feb 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: backport nextcloud-31 bump commits #759

chore: backport nextcloud-31 bump commits #759

Uh oh!

saw-jan commented Jan 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2025

Uh oh!

github-actions bot commented Jan 27, 2025

Uh oh!

nabim777 left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chore: backport nextcloud-31 bump commits #759

chore: backport nextcloud-31 bump commits #759

Uh oh!

Conversation

saw-jan commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related work packages

Types of changes

Checklist:

Uh oh!

github-actions bot commented Jan 27, 2025

JS Code Coverage

Uh oh!

github-actions bot commented Jan 27, 2025

PHP Code Coverage

Uh oh!

nabim777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

saw-jan commented Jan 24, 2025 •

edited

Loading