Get token with user OIDC events if necessary #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
enh/noid/get-token-with-user_oidc-events
branch
from
ef4fcd5 to
c044301
Compare
julien-nc
force-pushed
the
enh/noid/get-token-with-user_oidc-events
branch
2 times, most recently
from
8526e9b to
013f769
Compare
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/get-token-with-user_oidc-events
branch
from
013f769 to
98077e8
Compare
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/get-token-with-user_oidc-events
branch
from
98077e8 to
e5a7ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the "store login tokens" option is enabled in user_oidc, integration_swp should let user_oidc deal with token storage and refresh. We can use the
OCA\UserOIDC\Event\ExternalTokenRequestedEventevent to get an up-to-date token.If both integration_swp and user_oidc are trying to refresh the same token at some point, one of them will fail because its token is outdated.