Use unicode regex for email validation #3936
Open
+9
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milen Pivchev <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates email validation in the share functionality to support Unicode characters (such as ß, ü) instead of only ASCII characters, and adds whitespace trimming when searching for sharees. The email validation function is refactored from duplicate local functions to a single extension method.
- Replaced ASCII-only email regex with Unicode-aware regex pattern supporting international characters
- Consolidated duplicate
isValidEmailfunctions into a single extension method - Added whitespace trimming to the search functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Milen Pivchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email validation for shares did not allow special localized characters in emails (ex. ß), but switching the regex from ASCII to Unicode fixes the issue.