Fix lock not updating when disabling it via FaceID #3937
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milen Pivchev <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the UI state was not properly updated when disabling the passcode lock via Touch ID/Face ID biometric authentication. The fix ensures that the isLockActive binding is set to false when biometric validation successfully disables the lock.
- Added missing UI state update (
parent.isLockActive = false) in the biometric validation success handler - Renamed
enableTouchIDtoenableTouchFaceIDthroughout the codebase for better clarity - Added localization footer for the privacy screen section
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SetupPasscodeView.swift | Fixed UI state update by setting parent.isLockActive = false when lock is disabled via biometric auth; improved comment grammar |
| NCSettingsView.swift | Renamed enableTouchID to enableTouchFaceID for consistency; added footer text for privacy screen section |
| NCSettingsModel.swift | Renamed enableTouchID property to enableTouchFaceID throughout the model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Milen Pivchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Lock is disabled via Touch/FaceID, it will be disabled, but the UI will not get updated. This PR fixes this issue.