Skip to content

feat: add context chat provider #11150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
edward-ly wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: add context chat provider #11150

edward-ly wants to merge 30 commits into from

Conversation

@edward-ly
Copy link

@edward-ly edward-ly commented May 15, 2025

No description provided.

@welcome
Copy link

welcome bot commented May 15, 2025

Thanks for opening your first pull request in this repository! ✌️

@edward-ly edward-ly mentioned this pull request May 15, 2025
Closed
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 3, 2025

It was decided that we should move on with this without nextcloud/server#52852.

I'll look for a way to make Psalm understand the foreign code.

@edward-ly edward-ly force-pushed the feat/context-chat branch 2 times, most recently from 16633b0 to a359dd7 Compare June 18, 2025 23:46
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 26, 2025

It was decided that we should move on with this without nextcloud/server#52852.

I'll look for a way to make Psalm understand the foreign code.

Since we have to do workarounds to get Psalm working with stubs, have a stub update mechanism, and additionally need the actual classes to be able to write tests, we decided that nextcloud/server#52852 should be pursued again. It's also an investment of time, but we'll have our standard setup for app communication through the OCP public API. That setup works for Psalm and PHPUnit.

@edward-ly edward-ly force-pushed the feat/context-chat branch 2 times, most recently from c2efb0b to 6a236d3 Compare July 9, 2025 22:04
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 11, 2025
View reviewed changes
@edward-ly edward-ly force-pushed the feat/context-chat branch 3 times, most recently from dd566f9 to a7bc7ba Compare July 15, 2025 23:43
marcelklehr
marcelklehr reviewed Jul 17, 2025
View reviewed changes
@edward-ly edward-ly force-pushed the feat/context-chat branch 8 times, most recently from 52dcdfc to 9077fa6 Compare July 24, 2025 06:41
marcelklehr
marcelklehr reviewed Jul 24, 2025
View reviewed changes
marcelklehr
marcelklehr approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me! If we can finish the tests, I'd look forward to a review from the groupware team 💙

marcelklehr
marcelklehr reviewed Jul 24, 2025
View reviewed changes
marcelklehr
marcelklehr reviewed Jul 24, 2025
View reviewed changes
marcelklehr and others added 20 commits December 4, 2025 13:41
@marcelklehr
refactor: context chat integration
ad5d1af 
- rename Job to Task to make it easier to differentiate it from bg jobs
- simplify db schema
- change contentItem id to include mailbox id
- move message filtering into DB queries
- add lots of error handling

Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
test: Add unit tests for ContextChatProvider and SubmitContentJob
386e6a3 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Shorten table name
72f77a7 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
test: Complete unit tests for Context Chat integration
58b68db 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
test: Add tests for MessageMapper#findIdsAfter
827e196 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
test: Add tests for TaskMapper and TaskService
2fb22c5 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
test(SubmitContentJob): More failure tests
fa02ea5 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@edward-ly @marcelklehr
fix: update context chat constants
7c0d92f 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@edward-ly @marcelklehr
ci(workflows): remove stable31 from psalm, unit, and integration tests
05222ac 
Signed-off-by: Edward Ly <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
feat: Add opt-in setting for context chat
854442a 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Don't error if getItemUrl fails
3d308be 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Add TaskService#setLastMessage to avoid loop
50b1387 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Log error
86c6b58 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Add a ScheduleJob to schedule SubmitContentJob when the user has…
da32896 
… opted in

Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Mistake from rebasing
29040e4 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Mistake from rebasing
95973bf 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Mistake from rebasing
db4353f 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Appease psalm
bf2f0bc 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Appease eslint
ceaaca3 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Fix tests
b019e83 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr

This comment was marked as resolved.

Sign in to view
@marcelklehr
fix: Fix integration test
34d4ad1 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Fix integration test
b7fd55e 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
fix: Fix integration test
94afb80 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr marcelklehr marked this pull request as ready for review December 4, 2025 14:21
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 18, 2025

Unfortunately harp responds with HTTP400 now so I can't retest. Contacted @kyteinsky privately to get this resolved.

  • UX bug: even if the integration is turned off by admins I see Mail - mail in the context chat dialogue as user. This might cause confusion when someone tries to use it when it's actually off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@kyteinsky kyteinsky kyteinsky left review comments

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@ChristophWurst ChristophWurst

@edward-ly edward-ly

Labels

2. developing enhancement

Projects

💌 📅 👥 Groupware team
Status: 🏗️ In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@edward-ly @ChristophWurst @marcelklehr @kesselb @kyteinsky