Skip to content

enh: redesign email display on phones #11754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CreatorOfBiontium wants to merge 10 commits into from
Closed

enh: redesign email display on phones #11754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
95273e2
enh: displaying emails on phones redesign
CreatorOfBiontium Sep 27, 2025
44dda38
enh: align skeleton loading to left
CreatorOfBiontium Sep 27, 2025
1055abb
fix: phishing suspicion alert align
CreatorOfBiontium Sep 28, 2025
e1a3956
fix: fullsize email content under 600px
CreatorOfBiontium Oct 1, 2025
28bfd8a
fix: event div
CreatorOfBiontium Oct 8, 2025
5233aec
enh: show one line of subject
CreatorOfBiontium Oct 22, 2025
1c50c39
enh: pretty animation of collapsing subject
CreatorOfBiontium Nov 5, 2025
19bb877
Merge branch 'main' into enh/full_email_width_on_mobile
CreatorOfBiontium Nov 11, 2025
988e343
fix: code cleanup
CreatorOfBiontium Nov 16, 2025
cc10d44
fix: remove unnecesarry space
CreatorOfBiontium Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Imip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ export default {
&__type {
display: flex;
gap: 5px;
margin-inline-start: 36px;
margin-inline-start: 8px;
}

&__more-options {
Expand Down Expand Up @@ -606,7 +606,7 @@ export default {

&__actions {
margin-top: 15px;
margin-inline-start: 36px;
margin-inline-start: 8px;

&--buttons {
display: flex;
Expand Down
14 changes: 13 additions & 1 deletion src/components/Message.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,13 @@ export default {

.message-imip {
padding: 5px 10px;
margin-left: calc(var(--default-grid-baseline) * 11);
}

@media (max-width: 600px) {
.message-imip {
margin-left: 0;
}
}

.invalid-signature-warning {
Expand All @@ -201,7 +208,7 @@ export default {
}

.reply-buttons {
margin: 0 calc(var(--default-grid-baseline) * 4) calc(var(--default-grid-baseline) * 2) calc(var(--default-grid-baseline) * 14);
margin: 5px calc(var(--default-grid-baseline) * 3) calc(var(--default-grid-baseline) * 3) calc(var(--default-grid-baseline) * 14);
display: flex;
flex-wrap: wrap;
gap: 8px;
Expand All @@ -225,6 +232,11 @@ export default {
&__notsuggested {
margin-inline-start: auto;
}

@media (max-width: 600px) {
Copy link
Member

@ChristophWurst ChristophWurst Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a CSS var for the mobile breakpoint. Perhaps that would be a better option that the hard-coded 600px

Copy link
Contributor Author

@CreatorOfBiontium CreatorOfBiontium Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the --breakpoint-mobile: 1024px but 600-1024 px is wide enough to have an email displayed properly with the margin on the left. I'd keep it just for screens < 600px.

Copy link
Member

@ChristophWurst ChristophWurst Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. But for consistency I'd suggest we use the same breakpoint as in other places. There is no downside of the reduced left margin at 600-1024px.

Copy link
Contributor Author

@CreatorOfBiontium CreatorOfBiontium Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so I'll fix this else in the next commit or in the diffrent pr.

margin-left: calc(var(--default-grid-baseline) * 3);
margin-right: calc(var(--default-grid-baseline) * 3);
}
}

@media screen and (max-width: 600px) {
Expand Down
8 changes: 6 additions & 2 deletions src/components/MessageAttachments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,12 +287,16 @@ export default {
.mail-message-attachments {
display:flex;
flex-wrap: wrap;
padding: 10px 6px 10px 46px;
padding: 10px 12px 10px 46px;
margin-top: 4px;
margin-bottom: 0;
position:sticky;
bottom:0;
bottom: -2px;
background: linear-gradient(0deg, var(--color-main-background), var(--color-main-background) 90%, rgba(255, 255, 255, 0));

@media (max-width: 600px) {
Copy link
Member

@ChristophWurst ChristophWurst Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

padding: 10px 12px 10px 12px;
}
}

.mail-message-attachments--wrapper {
Expand Down
16 changes: 13 additions & 3 deletions src/components/MessageHTMLBody.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,21 +190,30 @@ export default {
</script>

<style lang="scss" scoped>
// account for 8px margin on iframe body
// account for 12px (was 8) margin on iframe body
// should be 12px so it maches the rest of the content
.html-message-body {
margin : 2px calc(var(--default-grid-baseline) * 2) 0 calc(var(--default-grid-baseline) * 14);
margin : 2px calc(var(--default-grid-baseline) * 3) 0 calc(var(--default-grid-baseline) * 14);
background-color: #FFFFFF;
border-radius: var(--border-radius-element);

@media (max-width: 600px) {
margin-left: calc(var(--default-grid-baseline) * 3);
margin-right: calc(var(--default-grid-baseline) * 3);
}
}

#mail-message-has-blocked-content {
margin-inline-start: 10px;
color: var(--color-text-maxcontrast) !important;
color: #000000 !important;
padding-top: 5px;
}

#message-container {
flex: 1;
display: flex;
background-color: #FFFFFF;
border-radius: var(--border-radius-element);

// TODO: collapse quoted text and remove inner scrollbar
@media only screen {
Expand All @@ -223,6 +232,7 @@ export default {

.message-frame {
width: 100%;
border-radius: var(--border-radius-element);
}

:deep(.button-vue__icon) {
Expand Down
6 changes: 6 additions & 0 deletions src/components/MessageLoadingSkeleton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,10 @@ export default {
}
}

@media only screen and (max-width: 600px) {
.message-loading-skeleton__body {
margin-inline-start: 12px;
}
}

</style>
21 changes: 13 additions & 8 deletions src/components/PhishingWarning.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,15 @@ export default {
<style lang="scss" scoped>
.phishing-warning {
background-color:rgba(var(--color-warning-rgb), 0.2);
border-radius: var(--border-radius);
text-align: start;
padding: 8px;
margin: calc(var(--default-grid-baseline) * 2);
border-radius: var(--border-radius-element);
text-align: start;
padding: 8px;
margin: calc(var(--default-grid-baseline) * 3);
// To match the html message margin
margin-inline-start: 50px;
margin-inline-start: calc(var(--default-grid-baseline) * 14);
&__title {
display: flex;
gap: 2px;
}
&__list {
list-style-position: inside;
Expand All @@ -86,11 +87,15 @@ export default {
word-wrap: break-word;
}
}
&__links {
margin-top: 10px;
&__links {
margin-top: 10px;
&__button{
margin-bottom: 10px;
}
}
}

@media (max-width: 600px) {
margin-inline-start: calc(var(--default-grid-baseline) * 3);
}
}
</style>
Loading