-
Notifications
You must be signed in to change notification settings - Fork 294
feat: make email wide on phone #12074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make email wide on phone #12074
Conversation
80f17ff to
1ed21fa
Compare
|
Hope I didn't forget anything @ChristophWurst. And while we are here, what to do with the animation, any suggestions, whether I should work on the way I did it in #11754 or leave it to someone else? |
|
I've pushed a small change to refactor how the mobile breakpoint works. Unfortunately using a css var for a media query is not supported yet. So we'll go with a SCSS var. |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested & works 🙏
c0d358b to
0f8b91f
Compare
|
Reworked the two commits. Main changes
|
A few changes, mainly focused on making email fully wide on phone, and a few design changes. Signed-off-by: Tobiáš Vašťák <[email protected]>
0f8b91f to
144d597
Compare
|
@CreatorOfBiontium please give this a final test to make sure I haven't lost anything in the clean-up 🙏 |
Signed-off-by: Christoph Wurst <[email protected]>
144d597 to
b9ba12a
Compare
|
@ChristophWurst Thanks, I have a lot to do this week, so I’d probably fix it over the weekend. I’ll test this when I get home. |
|
@ChristophWurst Tested and seems ok. My only concern is that in other languages, the unsub button is way too long, so it looks like this on narrow screens: Do you think we should fix this here by like ellipsies? Or follow up in #12076 (or somewhere else) - but still I think it's not gonna be that easy, or maybe, idk. |
|
We can leave it out here and solve one bug at a time :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |

A few changes, mainly focused on making email fully wide on phone, and a few design changes.
This is a split up of #11754
Fixes #11663