Skip to content

Conversation

@printminion-co
Copy link
Contributor

Added comprehensive unit tests for the UserDeletedListener to ensure proper handling of user deletion events, including scenarios with no accounts, single and multiple accounts, client exceptions, and partial failures. This enhances test coverage and reliability of the mail account deletion process.

In order for us to extend the logic in the future

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

Some smaller nitpicks, but overall a good initiative to add a test for it.

@printminion-co printminion-co force-pushed the mk/dev/test_user_delete_listener branch from 01dc5a4 to 460726a Compare December 2, 2025 15:03
Added comprehensive unit tests for the UserDeletedListener to ensure proper handling of user deletion events, including scenarios with no accounts, single and multiple accounts, client exceptions, and partial failures. This enhances test coverage and reliability of the mail account deletion process.

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@kesselb kesselb merged commit 063e700 into nextcloud:main Dec 2, 2025
44 checks passed
@printminion-co
Copy link
Contributor Author

/backport to stable5.5

@printminion-co
Copy link
Contributor Author

/backport to stable5.6

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants