Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 2, 2025

Fix #10475

This PR:

  • unit
  • integration with redis
  • integration without cache

Main:

  • 2x unit (if php8.3)
  • 4x integration (if mysql)

@kesselb kesselb requested a review from GretaD as a code owner December 2, 2025 19:30
@kesselb kesselb force-pushed the chore/noid/coverage-filter branch 3 times, most recently from d76e357 to 33c7a97 Compare December 2, 2025 20:08
@kesselb kesselb changed the title ci: only capture coverage once ci: less coverage runs Dec 2, 2025
@kesselb
Copy link
Contributor Author

kesselb commented Dec 2, 2025

@kesselb kesselb marked this pull request as draft December 2, 2025 20:21
@kesselb
Copy link
Contributor Author

kesselb commented Dec 2, 2025

Iteration 1:

https://app.codecov.io/github/nextcloud/mail/commit/e57d717fbf699b390f0c457629254f8aab62ff88/indirect-changes

1x unit
1x integration without redis

-0.26%

Iteration 2:

https://app.codecov.io/github/nextcloud/mail/commit/5b37ee7b31f07300ccbb00a0bd5c2972a8bc06d9/indirect-changes

1x unit
1x integration with redis

-26.81%

Iteration 3:

https://app.codecov.io/github/nextcloud/mail/commit/d76e357b8fec30ad81ddcecfbe2153aed8f38ece/indirect-changes

1x unit
2x integration (redis, no cache)

-0.21%

Iteration 4:

https://app.codecov.io/github/nextcloud/mail/commit/33c7a97bf99ba1e2c4d3b61b1ecf7b96eb02d006/indirect-changes

Same as Iteration 3, just with a reworded commit message.

1x unit
2x integration (redis, no cache)

-0.21%

Iteration 5:

https://app.codecov.io/github/nextcloud/mail/commit/e4bb57c6688c4b09e0579895a909518c6939ab03/indirect-changes

Same as Iteration 3 and 4, just another rebase to ensure the branch is not behind.

1x unit
2x integration (redis, no cache)

-0.21%

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the chore/noid/coverage-filter branch from 33c7a97 to e4bb57c Compare December 2, 2025 21:00
@kesselb kesselb marked this pull request as ready for review December 2, 2025 21:17
nextcloud-version: ${{ matrix.nextcloud-versions }}
php-version: ${{ matrix.php-versions }}
php-coverage: 'xdebug'
php-coverage: ${{ matrix.coverage && 'xdebug' || 'none' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub provides a way to create conditional logic in expressions using binary logical operators (&& and ||). This pattern can be used to achieve similar functionality to the ternary operator (?:) found in many programming languages, while actually using only binary operators.

TIL

@kesselb kesselb merged commit 4bf1746 into main Dec 3, 2025
58 of 66 checks passed
@kesselb kesselb deleted the chore/noid/coverage-filter branch December 3, 2025 11:11
@kesselb
Copy link
Contributor Author

kesselb commented Dec 4, 2025

/backport to stable5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check coverage matrix

3 participants