fix(ui): bind attr to popover trigger

[ChristophWurst]

Fixes

[Vue warn]: It looks like you are using a custom button as a <NcPopover> or other popover #trigger. If you are not using <NcButton> as a trigger, you need to bind attrs from the #trigger slot props to your custom button. See <NcPopover> docs for an example.

found in

---> <NcPopover>
       <NcActions>
         <RouterLink>
           <EnvelopeSkeleton> at src/components/EnvelopeSkeleton.vue
             <Envelope> at src/components/Envelope.vue
               <TransitionGroup>
                 <EnvelopeList> at src/components/EnvelopeList.vue
                   <Mailbox> at src/components/Mailbox.vue
                     <NcAppContentList>
                       <Pane>
                         <Splitpanes>
                           <NcAppContent>
                             <MailboxThread> at src/components/MailboxThread.vue
                               <NcContent>
                                 <Home> at src/views/Home.vue
                                   <App> at src/App.vue
                                     <Root>

after page load

From https://nextcloud-vue-components.netlify.app/#/Components/NcPopover

If you are using your own custom button as a trigger make sure to bind attrs from the trigger slot props.

[kesselb]

Thanks 👍

Why's that a custom button?

[ChristophWurst]

You are right, it doesn't need attr binding.

When is used as a trigger, it injects required for a11y attributes to the button.

[ChristophWurst]

Reverted the changes for anc NcButton triggers

[kesselb]

Thanks a lot 🥳

I was looking into that before, but I didn't find that one place where we were not using an NcButton 🙈

Finally that warning is gone 🎉

[kesselb]

/backport to stable5.6

[ChristophWurst]

I was looking into that before, but I didn't find that one place where we were not using an NcButton 🙈

There was also an nc-vue-internal usage that caused the warning. It's fixed by nextcloud-libraries/nextcloud-vue#7975