-
Notifications
You must be signed in to change notification settings - Fork 295
chore(ci): Switch to setup-php@verbose version due to stuck runs #12266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e184a97 to
42353c5
Compare
setup-php action to match them with the template repo|
@DerDreschner Had a look the changes, they look right... the CI run is the true test tho... I am surprised that some of those action versions where not updated by dependabot |
42353c5 to
88a4bbd
Compare
We try not to commit artifacts. They bloat the repository, you have to keep source and artifact in sync and it can lead to additional conflicts. Therefore we just generate these files when the package is built. |
Ahh, I see! I consider that best-practice to be honest and didn't expect the template repo to promote that with any workflows. Thanks! |
88a4bbd to
62cf30a
Compare
|
The version bumps for the other actions are unrelated; remove those. |
Signed-off-by: David Dreschner <github-2017@dreschner.net>
62cf30a to
10cd35d
Compare
Done. |
At least @SebastianKrupinski and myself experienced some workflow runs where the
set up phpstep stuck. As discussed in the talk channel, this seem to affect more people from within the company. It also happened today with thesetup-nextcloudworkflow action from @ChristophWurst , which tags@v2and therefore already uses the latest version:To be able to find the root cause for that issue, I've decided to switch the daily workflows to the
@verboseversion (see: https://github.com/shivammathur/setup-php?tab=readme-ov-file#verbose-setup). It might be worth to do that for thesetup-nextcloudworkflow as well, to get more verbose logging on possibly stuck runs faster.