fix(imap): pass through $loadBody in ImapMessageConnector::fetchMessages - #13628
Open
ChristophWurst wants to merge 19 commits into
Open
ChristophWurst wants to merge 19 commits into
ChristophWurst wants to merge 19 commits into
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Pure rename with no behavior or signature change, unrelated to the JMAP protocol work (flagged in review as noise). Restores the name main already uses. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
The rename touched the OCS route id (mail.messages.getSource -> ...getRawMessage) with no behavior change and no stated reason, unrelated to the JMAP protocol work. Restore the original name to drop this from the JMAP diff; the OCS route id and controller/service method name are back to what main already has. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
…bymessageid-rename refactor(imap): revert getMessagesByMessageId -> getByMessageId rename
…source-rename refactor(imap): revert getSource -> getRawMessage rename
findByIds() was always called with a hardcoded true for the load-body argument, ignoring the connector's own $loadBody parameter. Callers that explicitly request loadBody=false (e.g. for lightweight metadata-only fetches) silently got the full message body anyway. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findByIds() was always called with a hardcoded true for the load-body argument, ignoring the connector's own $loadBody parameter. Callers that explicitly request loadBody=false (e.g. for lightweight metadata-only fetches) silently got the full message body anyway.
Assisted-by: ClaudeCode:claude-opus-4-8
🤖 AI (if applicable)