-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi factor authentication for ssh #1037
base: devel
Are you sure you want to change the base?
multi factor authentication for ssh #1037
Conversation
Somehow the ncp app is currently broken, but only in the terminal ( |
@nachoparker I have now implemented the ability to supply a public key. However, it get's caught by the sanitization, because SSH public keys contain spaces (specifically at this line).
|
I have taken the liberty to implement the 3rd option as an example. If you are not fine with it, it can always be reverted. |
0c038af
to
9f7aa2b
Compare
bce49b4
to
b94764a
Compare
Hm, maybe it would be a good idea to add a few more text fields for ssh public keys... I'll implement that in a bit (don't merge yet 😉) |
@nachoparker Alright, it's feature complete now EDIT: Please note, that spaces (for fields which have 'allow_unsafe' set to true) will be shown as |
fb84268
to
9cf9ea8
Compare
Thanks! I will take a look soon, but I don't know when since I have family visits for the following weeks. |
Sure, take your time :) |
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
- Fix misspelled variable names Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
…l quotes) Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
…er was retrieved correctly. Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
…ssword reliant methods (not possible due to limitations of sshd configuration) Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
…p is enabled Signed-off-by: Tobias K <[email protected]> Signed-off-by: Tobias Knöppler <[email protected]>
a5cf782
to
8c1dc9f
Compare
e24d3a0
to
f032fd7
Compare
75bffeb
to
31d5ed9
Compare
f14678a
to
0e40867
Compare
As proposed in #1035 I implemented an ncp app to manage multi (and single) factor authentication methods. Currently supported are:
If multiple options are enabled, they will act as alternatives. However, if at least one mfa method is enabled, all single factor methods will be disabled automatically.
Also, it is unfortunately impossible to use totp (or any PAM based) authentication methods with non-PAM password authentication. That makes some combinations invalid, e.g. having pubkey+pw and totp+pw both enabled.
Functionality wise I'm satisfied with the current state of the ncp app now. The only missing things that I'm aware of are documentation and localization at this point.
TODO:
Provide QR-Code in web interface (?)Add localization