Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.3 #1955

Merged
merged 17 commits into from
Aug 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ee07434
ncp-update-nc: Use systemd-run to run update
theCalcaholic Aug 18, 2024
de9088f
release.yml: Add info about included software versions to release des…
theCalcaholic Aug 18, 2024
eea3d51
ncp-update-nc: Propagate debug flag
theCalcaholic Aug 18, 2024
1fb070d
ncp-update-nc: fix update termination detection
theCalcaholic Aug 18, 2024
0e30c79
build-lxd.yml: Pin nc version to update to before dist upgrade
theCalcaholic Aug 18, 2024
73da8fd
ncp.cfg,nc-nextcloud.cfg,ncp-app/: Add support for NC 29
theCalcaholic Aug 18, 2024
e05db18
update-nc.sh: Implement upgrade of PHP to 8.3
theCalcaholic Aug 18, 2024
335df8b
nextcloud_tests.py: Implement workaround for selenium selector issue
theCalcaholic Aug 18, 2024
4d9102a
update-nc.sh: Run maintenance:repair --include-expensive after update
theCalcaholic Aug 18, 2024
51a2d0f
update-nc.sh: Improve output if no new NC version is available
theCalcaholic Aug 19, 2024
eddb9d3
nextcloudpi/lib/SettingsService.php: Fix running commands in nonexist…
theCalcaholic Aug 19, 2024
2e38ecc
lamp.sh,ncp.cfg: Use PHP 8.3
theCalcaholic Aug 19, 2024
2838c59
build-lxd.yml: Use compatible repository versions to run tests
theCalcaholic Aug 19, 2024
92587ac
README.md: Update referred debian version
theCalcaholic Aug 19, 2024
6598d86
nc-encrypt.sh: Run gocryptfs as transient systemd service
theCalcaholic Aug 19, 2024
7612fd9
ncp.sh, 1.55.0.sh: Install logrotate
theCalcaholic Aug 20, 2024
e7a40c7
nextcloud_tests.py: Fix first run wizard close button not being detected
theCalcaholic Aug 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions .github/workflows/build-lxd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@v3
with:
ref: "${{ env.VERSION }}"
ref: "v1.54.3"
- name: Setup Firefox
continue-on-error: true
id: setup-firefox-browser-action
Expand Down Expand Up @@ -422,7 +422,7 @@ jobs:
sudo "$LXC" exec ncp -- "tail -n20 /var/log/ncp.log" || true
exit 1
}
python nextcloud_tests.py --no-gui --skip-release-check "nextcloudpi.local" 443 4443 || {
python nextcloud_tests.py --skip-release-check --no-gui "nextcloudpi.local" 443 4443 || {
echo "Nextcloud test failed!"
echo "Geckodriver logs:"
tail -n 20 geckodriver.log >&2 || true
Expand Down Expand Up @@ -457,7 +457,7 @@ jobs:
echo "Running update to ${VERSION}"

current_nc_version="$(sudo "$LXC" exec ncp -- ncc status | grep "version:" | awk '{ print $3 }')"
latest_nc_version="$(cat etc/ncp.cfg | jq -r '.nextcloud_version')"
latest_nc_version="27.0.1"

sudo "$LXC" exec ncp -- bash -c "DBG=x ncp-update ${UPDATE_ARGS[*]}"
sudo "$LXC" exec ncp -- /usr/local/bin/ncc status
Expand All @@ -467,6 +467,7 @@ jobs:
echo "Nextcloud is up to date - skipping NC update test."
else
sudo "$LXC" exec ncp -- bash -c "DBG=x ncp-update-nc ${latest_nc_version?}"
sudo "$LXC" exec ncp -- /usr/local/bin/ncc status
fi

sudo "$LXC" exec ncp -- rm -f /opt/ncdata/data/nextcloud.log
Expand Down Expand Up @@ -506,6 +507,10 @@ jobs:
echo "System test failed!"
exit 1
}
- name: Checkout current version
run: |
git fetch origin
git checkout "${{ env.VERSION }}"
- name: NCP distupgrade
id: distupgrade
run: |
Expand All @@ -514,7 +519,21 @@ jobs:
echo "can't upgrade from Debian $(sudo "$LXC" exec ncp -- cat /etc/os-release | grep VERSION_ID=)"
exit 1
}
current_nc_version="$(sudo "$LXC" exec ncp -- ncc status | grep "version:" | awk '{ print $3 }')"
latest_nc_version="$(cat etc/ncp.cfg | jq -r '.nextcloud_version')"

sudo "$LXC" exec ncp -- bash -c "DEBIAN_FRONTEND=noninteractive ncp-dist-upgrade"
sudo "$LXC" exec ncp -- /usr/local/bin/ncc status

if [[ "$current_nc_version" =~ "$latest_nc_version".* ]]
then
echo "Nextcloud is up to date - skipping NC update test."
else
sudo "$LXC" exec ncp -- bash -c "DBG=x ncp-update-nc ${latest_nc_version?}"
sudo "$LXC" exec ncp -- /usr/local/bin/ncc status
fi

sudo "$LXC" exec ncp -- rm -f /opt/ncdata/data/nextcloud.log

sudo "$LXC" exec ncp -- rm -f /opt/ncdata/data/nextcloud.log

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-sd-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ jobs:
echo '[Service]' | sudo tee raspbian_root/etc/systemd/system/redis-server.service.d/ncp.conf
echo 'PrivateUsers=false' | sudo tee -a raspbian_root/etc/systemd/system/redis-server.service.d/ncp.conf

sudo mkdir -p raspbian_root/etc/systemd/system/php8.1-fpm.service.d
echo '[Service]' | sudo tee raspbian_root/etc/systemd/system/php8.1-fpm.service.d/ncp.conf
echo 'ExecStartPre=mkdir -p /var/run/php' | sudo tee -a raspbian_root/etc/systemd/system/php8.1-fpm.service.d/ncp.conf
sudo mkdir -p raspbian_root/etc/systemd/system/php8.2-fpm.service.d
echo '[Service]' | sudo tee raspbian_root/etc/systemd/system/php8.2-fpm.service.d/ncp.conf
echo 'ExecStartPre=mkdir -p /var/run/php' | sudo tee -a raspbian_root/etc/systemd/system/php8.2-fpm.service.d/ncp.conf
- name: Test image
id: test
run: |
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,12 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |

NC_VERSION="$(jq -r '.nextcloud_version' < etc/ncp.cfg)"
PHP_VERSION="$(jq -r '.php_version' < etc/ncp.cfg)"
DEBIAN_VERSION="$(jq -r '.release' < etc/ncp.cfg)"
ARMBIAN_VERSIOn="$(cat build/armbian/armbian_version)"

subject="$(git tag -n10 --format="%(contents:subject)" "${{ env.VERSION }}")"
body="$(git tag -n30 --format="%(contents:body)" "${{ env.VERSION }}")"
separator="
Expand All @@ -334,6 +340,12 @@ jobs:

gh release create --draft -F - "${{ env.VERSION }}" <<EOF
${subject:-No message found}

### Included Software
Nextcloud ${NC_VERSION} (can be automatically updated to latest minor version)
PHP ${PHP_VERSION}
Debian ${DEBIAN_VERSION}
Armbian ${ARMBIAN_VERSION}

${body:+${body}${separator}}

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Please reach out in the [Matrix][chat-matrix-wiki] or [Telegram][chat-telegram-w

## Features

* Raspberry Pi OS/Debian 11 _(Bullseye)_
* Raspberry Pi OS/Debian 12 _(Bookworm)_
* Nextcloud
* Apache, with HTTP2 enabled
* PHP 8.1
Expand Down
Loading
Loading