Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optionally) run ncp apps in tmux #796

Open
wants to merge 22 commits into
base: devel
Choose a base branch
from

Conversation

theCalcaholic
Copy link
Collaborator

@theCalcaholic theCalcaholic commented Feb 8, 2019

I'm still testing this, but I figured, it wouldn't hurt to create a PR for reviewing/discussing.

This implements the execution of ncp apps in tmux if 'tmux: true' i set in their config.
For most purposes, I've tried to make an app to behave exactly the same when run via tmux as it does conventionally.

Features:

  • Run ncp apps in tmux (if configured)
  • Check if ncp app is already running in tmux before starting it
  • Load ('attach' to) execution output when selecting an ncp app in the web interface if it is running in tmux when attempting to launch an app from the web interface while one is running already

@theCalcaholic theCalcaholic changed the base branch from master to devel February 8, 2019 22:22
@theCalcaholic theCalcaholic changed the title [WIP] (Optionally) run ncp apps in tmux (Optionally) run ncp apps in tmux Feb 17, 2019
@theCalcaholic
Copy link
Collaborator Author

theCalcaholic commented Feb 17, 2019

Alright, I consider this PR complete now. Feel free to review and request changes :)

@nachoparker

Copy link
Member

@nachoparker nachoparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! see some comments but in general looks great

Also, in update.sh, move /var/log/ncp.log to the new location it if exists, also update the contents of /home/www/ncp-launcher.sh

.gitignore Outdated Show resolved Hide resolved
etc/library.sh Show resolved Hide resolved
etc/library.sh Outdated Show resolved Hide resolved
update.sh Outdated Show resolved Hide resolved
update.sh Outdated Show resolved Hide resolved
ncp-web/ncp-launcher.php Outdated Show resolved Hide resolved
ncp-web/ncp-launcher.php Outdated Show resolved Hide resolved
ncp-web/ncp-launcher.php Outdated Show resolved Hide resolved
ncp-web/js/ncp.js Outdated Show resolved Hide resolved
ncp-web/js/ncp.js Outdated Show resolved Hide resolved
ncp.sh Outdated Show resolved Hide resolved
@nachoparker
Copy link
Member

Looking better and better. So we are left with

  • update.sh
  • remove unused args

I know it's in progress, just making a list

@theCalcaholic
Copy link
Collaborator Author

@nachoparker Hm, what's missing in update.sh?

@nachoparker
Copy link
Member

Like I said above ;)

Also, in update.sh, move /var/log/ncp.log to the new location it if exists, also update the contents of /home/www/ncp-launcher.sh

@theCalcaholic
Copy link
Collaborator Author

theCalcaholic commented Feb 22, 2019

Like I said above ;)

Also, in update.sh, move /var/log/ncp.log to the new location it if exists, also update the contents of /home/www/ncp-launcher.sh

Oh the log is already being moved in update.sh

EDIT: See update.sh, line52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants