Skip to content

perf(push): Only get user language when needed #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Apr 9, 2024
Merged

perf(push): Only get user language when needed #1880

nickvergessen merged 1 commit into from
Apr 9, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 9, 2024 •
edited
Loading

Follow up to #1753

@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 9, 2024
@nickvergessen nickvergessen self-assigned this Apr 9, 2024
SystemKeeper
SystemKeeper approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@nickvergessen
Copy link
Member Author

nickvergessen commented Apr 9, 2024

/backport to stable29

@nickvergessen nickvergessen enabled auto-merge April 9, 2024 12:32
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8550 was 8200 (+4.26%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 3d56d81 into master Apr 9, 2024
@nickvergessen nickvergessen deleted the bugfix/noid/only-get-language-when-needed branch April 9, 2024 12:42
@backportbot backportbot bot mentioned this pull request Apr 9, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug feature: push 📲 performance

Projects

None yet

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @SystemKeeper @provokateurin