fix: Allow more specific object keys #182
Merged
+684
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
provokateurin
requested changes
Nov 11, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
The error message should probably be improved as well, to explain which types can be used besides string.
nickvergessen
force-pushed
the
bugfix/noid/allow-more-specific-object-keys
branch
from
befa43b to
c5e81e9
Compare
provokateurin
requested changes
Nov 12, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Please add some tests for this.
You could also re-use the same array for the check and the error message to avoid that they ever drift apart, but it's not that important.
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/allow-more-specific-object-keys
branch
from
c5e81e9 to
ce0c021
Compare
provokateurin
approved these changes
Nov 12, 2024
Member
Author
|
So merge and release, so notifications can go green again? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.