feat(deprecation): Allow deprecating parameters of controller methods #219
Conversation
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
I fear this implementation is not compatible with #214 and I would really like to get that PR merged first and avoid rebasing it.
|
Please try a rebase, hopefully you don't need to change too much 🤞 |
nickvergessen
force-pushed
the
bugfix/217/allow-deprecating-parameters
branch
from
2f26338 to
0a5e7b6
Compare
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Deprecated parameters for GET methods don't seem to work correctly.
| if (str_contains($param->type->description, '@deprecated')) { | ||
| $param->type->deprecated = true; | ||
| } |
There was a problem hiding this comment.
I would suggest replacing @deprecated with Deprecated: in the description to make it a bit more readable like a normal sentence.
There was a problem hiding this comment.
But then we loose IDE highlighting:
There was a problem hiding this comment.
I only meant in the OpenAPI output, not in the phpdocs.
There was a problem hiding this comment.
Ah, in the parsed openapi.json
We can try that
nickvergessen
force-pushed
the
bugfix/217/allow-deprecating-parameters
branch
from
0a5e7b6 to
4badf2a
Compare
|
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/217/allow-deprecating-parameters
branch
from
4badf2a to
aad84fd
Compare
Signed-off-by: Joas Schilling <[email protected]>
Fix #217