-
Notifications
You must be signed in to change notification settings - Fork 4
fix(merge-specs): Use objects instead of associative arrays to fix empty JSON objects #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dc0ad4c to
e62c393
Compare
|
Is this testable? :-X |
|
I'll open a draft PR in documentation, then you can modify it to use openapi-extractor from path and check the diff. |
|
You can now test it with nextcloud/documentation#12887. |
|
But on this topic, I was thinking of maybe adding the merged spec to the server repo (in the root folder) and then we can also run it as part of the CI here to check for any diffs or failures. It wouldn't even need any adjustments in this repo, just in server. |
|
yeah that's what I meant |
e62c393 to
5ec759a
Compare
Signed-off-by: provokateurin <[email protected]>
…pty JSON objects Signed-off-by: provokateurin <[email protected]>
5ec759a to
b71a6e5
Compare
|
@nickvergessen can you check again, so we can merge the PR and close the topic? |
|
I don't have time at the moment, so just merge it I guess? |
#225
Otherwise
{}from JSON will turn into[]in PHP and then into[]in JSON which is not valid.