Skip to content

fix(merge-specs): Trim off scope from app ID #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Mar 24, 2025
Merged

fix(merge-specs): Trim off scope from app ID #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions merge-specs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,12 @@ function loadSpec(string $path): array {
return rewriteRefs(json_decode(file_get_contents($path), true));
}

function getAppID(array $spec): string {
return explode('-', $spec['info']['title'])[0];
}

function rewriteRefs(array $spec): array {
$readableAppID = Helpers::generateReadableAppID($spec['info']['title']);
$readableAppID = Helpers::generateReadableAppID(getAppID($spec));
array_walk_recursive($spec, function (mixed &$item, string $key) use ($readableAppID): void {
if ($key === '$ref' && $item !== '#/components/schemas/OCSMeta') {
$item = str_replace('#/components/schemas/', '#/components/schemas/' . $readableAppID, $item);
Expand All @@ -115,7 +119,7 @@ function rewriteRefs(array $spec): array {

function collectCapabilities(array $spec): array {
$capabilities = [];
$readableAppID = Helpers::generateReadableAppID($spec['info']['title']);
$readableAppID = Helpers::generateReadableAppID(getAppID($spec));
foreach (array_keys($spec['components']['schemas']) as $name) {
if ($name == 'Capabilities' || $name == 'PublicCapabilities') {
$capabilities[] = $readableAppID . $name;
Expand All @@ -127,7 +131,7 @@ function collectCapabilities(array $spec): array {

function rewriteSchemaNames(array $spec): array {
$schemas = $spec['components']['schemas'];
$readableAppID = Helpers::generateReadableAppID($spec['info']['title']);
$readableAppID = Helpers::generateReadableAppID(getAppID($spec));
return array_combine(
array_map(fn (string $key): string => $key === 'OCSMeta' ? $key : $readableAppID . $key, array_keys($schemas)),
array_values($schemas),
Expand All @@ -136,7 +140,7 @@ function rewriteSchemaNames(array $spec): array {

function rewriteTags(array $spec): array {
return array_map(function (array $tag) use ($spec) {
$tag['name'] = $spec['info']['title'] . '/' . $tag['name'];
$tag['name'] = getAppID($spec) . '/' . $tag['name'];
return $tag;
}, $spec['tags']);
}
Expand All @@ -151,12 +155,12 @@ function rewriteOperations(array $spec): array {
}
$operation = &$spec['paths'][$path][$method];
if (array_key_exists('operationId', $operation)) {
$operation['operationId'] = $spec['info']['title'] . '-' . $operation['operationId'];
$operation['operationId'] = getAppID($spec) . '-' . $operation['operationId'];
}
if (array_key_exists('tags', $operation)) {
$operation['tags'] = array_map(fn (string $tag): string => $spec['info']['title'] . '/' . $tag, $operation['tags']);
$operation['tags'] = array_map(fn (string $tag): string => getAppID($spec) . '/' . $tag, $operation['tags']);
} else {
$operation['tags'] = [$spec['info']['title']];
$operation['tags'] = [getAppID($spec)];
}
if ($firstStatusCode && array_key_exists('responses', $operation)) {
/** @var string $value */
Expand Down
Loading